de4a-eu / xml-schemas

DE4A WP5 authoritative XML Schemas
Creative Commons Attribution 4.0 International
1 stars 1 forks source link

Length limits in XML Schema are inconsistent #35

Closed phax closed 2 years ago

phax commented 2 years ago

In many cases, you try to limit the XML Schema types with a maxLength. In certain cases this is however not done, as e.g. with:

In general it is imho bad practise to length limit the types in the XML Schema - that should be done on an upper level of the application.

aosunacab commented 2 years ago

It might considerate to limitate the data content in advance, I mean, the data processor (e.g. DO) could control data contents, length among others, but the message is already sent, It could be reasonable to have some limitations in advance?, as a first filter, furthermore those limitations were consensuated from the beggining in the model, I guess.

what do you think?

phax commented 2 years ago

Yes I agree. But I don't know what that exactly means. What technical solutions do you have in mind?

aosunacab commented 2 years ago

No, nothing to do with a technical solution, just I think that it doesn't hurt to have a data fits limitations

phax commented 2 years ago

Okay. Yes I agree with that - but I think the length restrictions should all be on the same place. So either all in XSD or all somewhere else. My best guess would be a Schematron, but I know you are reluctant to that

aosunacab commented 2 years ago

Indeed I am supporter of Schematron, but it was a members decision not to apply that validation layer level for this purposes. So, in this case, maybe we can include more lenght or whatever limitations in the XSDs as workaround

aosunacab commented 2 years ago

So, if some extra validation or limits update raise we will include them on the fly. May we close this issue by now?

phax commented 2 years ago

Fine for me