de4a-eu / xml-schemas

DE4A WP5 authoritative XML Schemas
Creative Commons Attribution 4.0 International
1 stars 1 forks source link

Beauty contest - list elements #44

Closed phax closed 2 years ago

phax commented 2 years ago

Quick question: do we really need the AdditionalParameters elements that are optional and contain 1-n AdditionalParameter elements?

To simplify the XML we could simply say use 0-n AdditionalParameter elements instead.

So instead of

...
  <p1:CanonicalEvidenceTypeId>p1:CanonicalEvidenceId</p1:CanonicalEvidenceTypeId>
  <p1:AdditionalParameters>
    <p1:AdditionalParameter xml:lang="en">
      <p1:Label>p1:Label</p1:Label>
      <p1:Type>Date</p1:Type>
      <p1:Value>p1:Value</p1:Value>
    </p1:AdditionalParameter>
  </p1:AdditionalParameters>
</p:RequestExtractEvidence>

we could write

...
  <p1:CanonicalEvidenceTypeId>p1:CanonicalEvidenceId</p1:CanonicalEvidenceTypeId>
  <p1:AdditionalParameter xml:lang="en">
    <p1:Label>p1:Label</p1:Label>
    <p1:Type>Date</p1:Type>
    <p1:Value>p1:Value</p1:Value>
  </p1:AdditionalParameter>
</p:RequestExtractEvidence>

(based on Iteration 1 examples)

aosunacab commented 2 years ago

Yes, Indeed it was ok in the new type, it was used just by an old one