Closed Be-El closed 5 years ago
Hello @Be-El! Thanks for updating the PR.
In the file denbi/perun/keystone.py
, following are the PEP8 issues :
Line 14:80: E501 line too long (104 > 79 characters) Line 15:80: E501 line too long (115 > 79 characters) Line 17:80: E501 line too long (111 > 79 characters) Line 19:80: E501 line too long (103 > 79 characters) Line 21:80: E501 line too long (95 > 79 characters) Line 37:80: E501 line too long (91 > 79 characters) Line 40:80: E501 line too long (84 > 79 characters) Line 41:80: E501 line too long (93 > 79 characters) Line 42:80: E501 line too long (85 > 79 characters) Line 43:80: E501 line too long (89 > 79 characters) Line 44:80: E501 line too long (114 > 79 characters) Line 51:80: E501 line too long (89 > 79 characters) Line 67:80: E501 line too long (103 > 79 characters) Line 73:80: E501 line too long (151 > 79 characters) Line 85:80: E501 line too long (121 > 79 characters) Line 87:80: E501 line too long (115 > 79 characters) Line 89:80: E501 line too long (143 > 79 characters) Line 106:80: E501 line too long (92 > 79 characters) Line 109:80: E501 line too long (82 > 79 characters) Line 111:80: E501 line too long (108 > 79 characters) Line 113:80: E501 line too long (107 > 79 characters) Line 146:80: E501 line too long (142 > 79 characters) Line 171:80: E501 line too long (81 > 79 characters) Line 174:80: E501 line too long (113 > 79 characters) Line 178:80: E501 line too long (90 > 79 characters) Line 210:80: E501 line too long (117 > 79 characters) Line 211:80: E501 line too long (109 > 79 characters) Line 236:80: E501 line too long (86 > 79 characters) Line 238:80: E501 line too long (94 > 79 characters) Line 262:80: E501 line too long (80 > 79 characters) Line 264:80: E501 line too long (83 > 79 characters) Line 265:80: E501 line too long (83 > 79 characters) Line 276:80: E501 line too long (86 > 79 characters) Line 282:80: E501 line too long (129 > 79 characters) Line 288:80: E501 line too long (85 > 79 characters) Line 291:80: E501 line too long (87 > 79 characters) Line 297:80: E501 line too long (82 > 79 characters) Line 298:80: E501 line too long (93 > 79 characters) Line 307:80: E501 line too long (84 > 79 characters) Line 311:80: E501 line too long (97 > 79 characters) Line 316:80: E501 line too long (89 > 79 characters) Line 321:80: E501 line too long (106 > 79 characters) Line 331:80: E501 line too long (84 > 79 characters) Line 353:80: E501 line too long (85 > 79 characters) Line 385:80: E501 line too long (114 > 79 characters) Line 405:80: E501 line too long (117 > 79 characters) Line 445:80: E501 line too long (114 > 79 characters) Line 446:80: E501 line too long (121 > 79 characters) Line 458:80: E501 line too long (114 > 79 characters) Line 477:80: E501 line too long (115 > 79 characters) Line 479:80: E501 line too long (93 > 79 characters) Line 485:80: E501 line too long (129 > 79 characters) Line 490:80: E501 line too long (84 > 79 characters) Line 505:80: E501 line too long (93 > 79 characters) Line 506:80: E501 line too long (81 > 79 characters) Line 510:80: E501 line too long (80 > 79 characters) Line 512:80: E501 line too long (109 > 79 characters) Line 514:80: E501 line too long (116 > 79 characters) Line 515:80: E501 line too long (99 > 79 characters) Line 537:80: E501 line too long (89 > 79 characters) Line 540:80: E501 line too long (83 > 79 characters) Line 547:80: E501 line too long (87 > 79 characters) Line 565:80: E501 line too long (89 > 79 characters) Line 568:80: E501 line too long (83 > 79 characters) Line 575:80: E501 line too long (88 > 79 characters)
In the file denbi/scripts/perun_propagation.py
, following are the PEP8 issues :
Line 25:80: E501 line too long (84 > 79 characters) Line 37:80: E501 line too long (96 > 79 characters) Line 38:80: E501 line too long (109 > 79 characters) Line 40:80: E501 line too long (92 > 79 characters) Line 42:80: E501 line too long (86 > 79 characters) Line 44:80: E501 line too long (102 > 79 characters)
In the file denbi/scripts/perun_propagation_service.py
, following are the PEP8 issues :
Line 17:80: E501 line too long (98 > 79 characters) Line 18:80: E501 line too long (86 > 79 characters) Line 34:80: E501 line too long (105 > 79 characters) Line 49:80: E501 line too long (93 > 79 characters) Line 58:80: E501 line too long (80 > 79 characters) Line 59:80: E501 line too long (91 > 79 characters) Line 68:80: E501 line too long (85 > 79 characters) Line 75:80: E501 line too long (84 > 79 characters) Line 77:80: E501 line too long (81 > 79 characters) Line 78:80: E501 line too long (109 > 79 characters) Line 80:80: E501 line too long (92 > 79 characters) Line 82:80: E501 line too long (86 > 79 characters)
Fixes in this branch:
Tested with domain admin credentials on test domain: blinke@bcf-pc01:~/source/perunKeystoneAdapter$ python denbi/scripts/perun_propagation.py --role member -v -v --domain 4d5930b754054c1e874b06d382374a97 test/resources/perun.tar.gz DEBUG:denbi:Working on domain 4d5930b754054c1e874b06d382374a97 DEBUG:denbi:Using existing default role member (id 9fe2ff9ee4384b1894a90878d3e92bab) INFO:denbi.perun.endpoint:Importing data mode=denbi_portal_compute_center users_path=/tmp/tmpmQVsiy/users.scim groups_path=/tmp/tmpmQVsiy/groups.scim DEBUG:denbi:Found denbi associated project Test Projekt (id 5cd05f4c26f847c1bcf5f335a926b599) DEBUG:denbi:Found user 6a5ac1b6a502463cab237c844bc2ad82 as member in project Test Projekt DEBUG:denbi:Found user 7689c2ce3b9847bf8a97e0f0ef53d48e as member in project Test Projekt DEBUG:denbi:Found user 86fa95b194f74164b3cefdbc1b9c2585 as member in project Test Projekt DEBUG:denbi:Found denbi associated project Test Projekt 2 (id 2e9c820106fd487683d0a383601b56b4) DEBUG:denbi:Found user 60d9d2c32a044651be6be1e15333ffc6 as member in project Test Projekt 2
Keep in mind that domain admins cannot list all domains; domain lookups by name will fail. You need to pass the domain as id if you want to use domain admin credentials. Fallback to default behaviour for cloud admins and name based lookups if present, but currently untested.
Fixes #23, fixes #22