Fix/logging - Githubissues

deNBI / perunKeystoneAdapter

Perun Keystone Adapter parses data propagated by Perun data and modifies a connected Keystone.

https://perunkeystoneadapter.readthedocs.io/en/latest/

Apache License 2.0

5 stars 0 forks source link

Fix/logging #33

Closed jkrue closed 5 years ago

jkrue commented 5 years ago

resolves #30

pep8speaks commented 5 years ago

Hello @jkrue! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file denbi/perun/keystone.py:

Line 401:181: E501 line too long (200 > 180 characters) Line 535:181: E501 line too long (187 > 180 characters)

Comment last updated at 2019-05-03 12:50:43 UTC

awalende commented 5 years ago

Gave some opinions on the logging "style". Otherwise Iam liking the idea with the different logger domains.

jkrue commented 5 years ago

The logging style can be easily adjusted. See https://docs.python.org/3.5/howto/logging.html. I should document this better ... in the code and also in the service example. @awalende Thx

jkrue commented 5 years ago

@pbelmann Do have an idea what's going wrong here ? Seems that travis changes something in behind ... the test itself did not change for month