search

deactivated / python-iso3166

Standalone ISO 3166-1 country definitions
MIT License
140 stars 39 forks source link

Outdated list of countries #37

Open detrin opened 3 months ago

detrin commented 3 months ago

For example, Kosovo is no longer in https://en.wikipedia.org/wiki/ISO_3166-1

I could open a PR. I think even better is create a job that will check the list with scraping wiki on weekly basis. I will try to prepare that

detrin commented 3 months ago

I prepared a repo where you can use the CLI to fetch the newest ISO 3166 list or use the countries.json file. https://github.com/detrin/download-iso3166-list

detrin commented 3 months ago

Opened PR https://github.com/deactivated/python-iso3166/pull/38

detrin commented 3 months ago

also opened PR for the script check https://github.com/deactivated/python-iso3166/pull/39

deactivated commented 2 months ago

Hi @detrin,

Thanks for the interest. The XK alpha-2 code is a defacto standard in use by a number of international organizations (see Wikipedia for a partial list).

I don't intend to remove the entry, however, I would be open to a PR that adds a status field to each entry.

detrin commented 2 months ago

@deactivated I see you closed both my PRs, so my effort goes for nothing 😐

As of now the repo itself depends on people noticing you about the ISO updates in issues. I have noticed that it is normal that repos containing ISO 3166 have inconsistencies in it, that have to be resolved manually. Especially this package is for python, which is commonly used in feature engineering in datascience.

Ad Kosovo, Kosovo is not in ISO 3166-1 list, hence if you present this repo as ISO 3166 list and you have Kosovo in it, it is not really true information. The result is that someone my consider Kosovo in the list, someone may not, but if the python package is named iso3166 I believe it should contain true information about ISO 3166. You could create optional argument that would be opt-in and not opt-out for ISO 3166 - extended for example and explicitly mention that with Kosovo case in README.

I think there are those two issues 1) updating/checking and 2) consistency.