About the artifact location

[chenrui333]

👋 just a question about the artifact location.

https://github.com/deadc0de6/dotdrop/blob/f8a70dc58ad341d0dd1b9cfe7a9fc2f6d62babf6/.github/workflows/homebrew-manual.yml#L20

homebrew actually prefers the pypi source as we can resolve the dependency updates along with the PR bump, can we remove that line? Thanks!

[chenrui333]

This would be the diff if we drop that line

diff --git a/Formula/dotdrop.rb b/Formula/dotdrop.rb
index 9d66d09483e..e89c0b9a14f 100644
--- a/Formula/dotdrop.rb
+++ b/Formula/dotdrop.rb
@@ -3,8 +3,8 @@ class Dotdrop < Formula

   desc "Save your dotfiles once, deploy them everywhere"
   homepage "https://deadc0de.re/dotdrop"
-  url "https://github.com/deadc0de6/dotdrop/archive/v1.12.4.tar.gz"
-  sha256 "d2b1456da19d1fe795f5681ca2adff321812cc28ae53fcf397972b1b9b6d74c2"
+  url "https://files.pythonhosted.org/packages/a7/ed/6c24d9ab04e483b16dacf0fc4e7de26b90b9f46801537a69db4c62674aab/dotdrop-1.12.4.tar.gz"
+  sha256 "1630cd14aa3495b3de4eb3c1dbdc8f9566cfe52a1dbaaff127167215b798a0ba"
   license "GPL-3.0-or-later"

   bottle do
@@ -26,8 +26,8 @@ class Dotdrop < Formula
   end

   resource "charset-normalizer" do
-    url "https://files.pythonhosted.org/packages/a1/34/44964211e5410b051e4b8d2869c470ae8a68ae274953b1c7de6d98bbcf94/charset-normalizer-2.1.1.tar.gz"
-    sha256 "5a3d016c7c547f69d6f81fb0db9449ce888b418b5b9952cc5e6e66843e9dd845"
+    url "https://files.pythonhosted.org/packages/96/d7/1675d9089a1f4677df5eb29c3f8b064aa1e70c1251a0a8a127803158942d/charset-normalizer-3.0.1.tar.gz"
+    sha256 "ebea339af930f8ca5d7a699b921106c6e29c617fe9606fa7baa043c1cdae326f"
   end

   resource "distro" do
@@ -56,8 +56,8 @@ class Dotdrop < Formula
   end

   resource "packaging" do
-    url "https://files.pythonhosted.org/packages/6b/f7/c240d7654ddd2d2f3f328d8468d4f1f876865f6b9038b146bec0a6737c65/packaging-22.0.tar.gz"
-    sha256 "2198ec20bd4c017b8f9717e00f0c8714076fc2fd93816750ab48e2c41de2cfd3"
+    url "https://files.pythonhosted.org/packages/47/d5/aca8ff6f49aa5565df1c826e7bf5e85a6df852ee063600c1efa5b932968c/packaging-23.0.tar.gz"
+    sha256 "b6ad297f8907de0fa2fe1ccbd26fdaf387f5f47c7275fedf8cce89f99446cf97"
   end
:...skipping...
diff --git a/Formula/dotdrop.rb b/Formula/dotdrop.rb
index 9d66d09483e..e89c0b9a14f 100644
--- a/Formula/dotdrop.rb
+++ b/Formula/dotdrop.rb
@@ -3,8 +3,8 @@ class Dotdrop < Formula

   desc "Save your dotfiles once, deploy them everywhere"
   homepage "https://deadc0de.re/dotdrop"
-  url "https://github.com/deadc0de6/dotdrop/archive/v1.12.4.tar.gz"
-  sha256 "d2b1456da19d1fe795f5681ca2adff321812cc28ae53fcf397972b1b9b6d74c2"
+  url "https://files.pythonhosted.org/packages/a7/ed/6c24d9ab04e483b16dacf0fc4e7de26b90b9f46801537a69db4c62674aab/dotdrop-1.12.4.tar.gz"
+  sha256 "1630cd14aa3495b3de4eb3c1dbdc8f9566cfe52a1dbaaff127167215b798a0ba"
   license "GPL-3.0-or-later"

   bottle do
@@ -26,8 +26,8 @@ class Dotdrop < Formula
   end

   resource "charset-normalizer" do
-    url "https://files.pythonhosted.org/packages/a1/34/44964211e5410b051e4b8d2869c470ae8a68ae274953b1c7de6d98bbcf94/charset-normalizer-2.1.1.tar.gz"
-    sha256 "5a3d016c7c547f69d6f81fb0db9449ce888b418b5b9952cc5e6e66843e9dd845"
+    url "https://files.pythonhosted.org/packages/96/d7/1675d9089a1f4677df5eb29c3f8b064aa1e70c1251a0a8a127803158942d/charset-normalizer-3.0.1.tar.gz"
+    sha256 "ebea339af930f8ca5d7a699b921106c6e29c617fe9606fa7baa043c1cdae326f"
   end

   resource "distro" do
@@ -56,8 +56,8 @@ class Dotdrop < Formula
   end

   resource "packaging" do
-    url "https://files.pythonhosted.org/packages/6b/f7/c240d7654ddd2d2f3f328d8468d4f1f876865f6b9038b146bec0a6737c65/packaging-22.0.tar.gz"
-    sha256 "2198ec20bd4c017b8f9717e00f0c8714076fc2fd93816750ab48e2c41de2cfd3"
+    url "https://files.pythonhosted.org/packages/47/d5/aca8ff6f49aa5565df1c826e7bf5e85a6df852ee063600c1efa5b932968c/packaging-23.0.tar.gz"
+    sha256 "b6ad297f8907de0fa2fe1ccbd26fdaf387f5f47c7275fedf8cce89f99446cf97"
   end

   resource "python-magic" do
@@ -66,8 +66,8 @@ class Dotdrop < Formula
   end

   resource "requests" do
2.28.1.tar.gz"
-    sha256 "7c5599b102feddaa661c826c56ab4fee28bfd17f5abca1ebbe3e7f19d7c97983"
2.28.2.tar.gz"
+    sha256 "98b1b2782e3c6c4904938b84c0eb932721069dfdb9134313beff7c83c2df24bf"
   end

   resource "ruamel.yaml" do
@@ -81,8 +81,8 @@ class Dotdrop < Formula
   end

   resource "urllib3" do
.26.13.tar.gz"
-    sha256 "c083dd0dce68dbfbe1129d5271cb90f9447dea7d52097c6e0126120c521ddea8"
.26.14.tar.gz"
+    sha256 "076907bf8fd355cde77728471316625a4d2f7e713c125f51953bb5b3eecf4f72"
   end

   def instal

[deadc0de6]

@chenrui333 You are absolutely right, I switched github action and didn't actually realized it would generated the PR using github artifacts. I'm closing the current PR (https://github.com/Homebrew/homebrew-core/pull/120525) and will create a new one. Sorry for that!

[deadc0de6]

@chenrui333 here's the new PR: https://github.com/Homebrew/homebrew-core/pull/120596

[chenrui333]

@chenrui333 You are absolutely right, I switched github action and didn't actually realized it would generated the PR using github artifacts. I'm closing the current PR (Homebrew/homebrew-core#120525) and will create a new one. Sorry for that!

that makes sense! thanks!

thanks @deadc0de6!! :)