Bug#388 - fix negative ignore

deadc0de6 / dotdrop

Save your dotfiles once, deploy them everywhere

https://dotdrop.readthedocs.io

GNU General Public License v3.0

1.77k stars 105 forks source link

Bug#388 - fix negative ignore #389

Closed deadc0de6 closed 11 months ago

deadc0de6 commented 1 year ago

This should fix #388 and improve tests for negative ignore patterns

instignore for install
impignore for import
cmpignore for compare
upignore for ignore

In particular it should fix

ignore are tested twice (for is_template and for the action itself)
at least update is not working properly on directory

coveralls commented 1 year ago

coverage: 91.072% (+0.1%) from 90.974% when pulling 7dca57c2420784790980eb260d7c418c11064123 on bug#388 into 58318fd13c6c631de9a9604422fa00529bb8dd3d on master.

deadc0de6 commented 1 year ago

All actions (compare, import, install, update) should all descend into directories if a negative ignore pattern is found!

The following tests should ensure this is done properly:

compare-negative-ignore-all-but.sh
import-negative-ignore-all-but.sh
install-negative-ignore-all-but.sh
update-negative-ignore-all-but.sh

deadc0de6 commented 11 months ago

replaced by #402