search

deadc0de6 / dotdrop

Save your dotfiles once, deploy them everywhere
https://dotdrop.readthedocs.io
GNU General Public License v3.0
1.77k stars 105 forks source link

Bug fix: follow symlinks when templating a source file that is a symlink #394

Closed jtt9340 closed 1 year ago

jtt9340 commented 1 year ago

I noticed a bug (or at least a bug to me :wink:) where if the template engine is asked to process a file that is a symlink to a template, the template engine thinks the symlink is a binary file and skips it, when it should probably follow the symlink to see if it is actually a templated text file or a binary file.

My particular use case is that some files in my dotfiles repo are symlinks to other files in the repo, which happen to be templated. When dotdrop installs the dotfiles for that directory containing symlinks, it wasn't templating the files pointed to by the symlinks because it wasn't following the symlink.

coveralls commented 1 year ago

Coverage Status

coverage: 91.049% (+0.06%) from 90.987% when pulling ee653e007cb27a18cba7d2dde99bf17ab5b190ea on jtt9340:follow-symlinks into a2de4cfb0c2b143559799858df4c3ab0851fe769 on deadc0de6:master.

deadc0de6 commented 1 year ago

Pretty cool, thanks a lot for your work :+1: Thanks also for the test case!