deadeyejoe / deck

Board games written in clojure with a polylith architecture
MIT License
4 stars 2 forks source link

Two planets have the wrong names #1

Closed Ymbirtt closed 1 year ago

Ymbirtt commented 1 year ago

Using this map as an example: https://conclave.mistake-not.net/#WyJeICIsIn46diIsMSwifjp0IiwiMTggNzggMjkgNDYgMzggNDggNjUgMjMgNDcgNDIgMjEgNDkgNzMgMzAgMzkgNjQgMzcgMzYgNjcgMjQgNzAgNjEgUDIgMzEgMzQgUDMgMzUgNDQgUDQgNzcgNjYgNjAgUDUgODAgNzYgMjIgUDEiXQ==

System tile 61 at coordinates 2, 1, -3 is mislabelled as containing the planet "Perimeter" in the bottom right of the screen while hovering:

image

Looking at the tile image, this planet should be called Ang. This is also the case for system tile 73, where Cealdri is misidentified as Lisis.

Ymbirtt commented 1 year ago

Thanks - incidentally, do you have some brief notes on how to run a local copy of this? I'm interested in adding another couple of bits and pieces if I find the time.

deadeyejoe commented 1 year ago

Sure I can write some up. Are you familiar with clojure or clojurescript at all? What would you be thinking of adding?

Ymbirtt commented 1 year ago

I'm afraid I'm totally new to the Clojue ecosystem, though snooping around your other repos I've found your Codenames project, which does seem to include some documentation. If that's relevant to Conclave, I can give that a shot?

Because of the number of friends I have, I usually play 5 player games, so was hoping to add in definitions for the 5-player notch and flat maps:

image image

Looking at your definitions in data/layouts.cljc, though, it looks like it'd be fairly straightforward to add them. The layouts are available on other map generators, but Derek Peterson's generator doesn't support PoK, while Keeganw's tends to produce fairly unbalanced notch maps - I often find that the players on the "horns" only have one "safe" planet next to their home system, while the other players have three solid, immediately useful systems to start colonising. I'm hoping that your balancing algorithm will do a better job!

deadeyejoe commented 1 year ago

Sorry for the late response, busy weekend!

Cool you want to add those maps! Adding new layouts was one of the things I was aiming at when I wrote the app, so it should just be a matter of adding to layouts.cljc. I also wrote the balancing algorithm to be as layout-agnostic as possible, so hopefully it'll give you decent results - can't promise that obviously, but if you do notice problems/persistent biases please let me know.

I'm gonna write up a quick readme for it now. The instructions you mention for the codenames app are basically just gesturing at other people's documentation, so I reckon they could be tough to follow.

deadeyejoe commented 1 year ago

Added a readme just now, hopefully it's clear, let me know what you think!