deadfoxygrandpa / Elm.tmLanguage

Elm language syntax highlighting and tool integration for ST2/3
https://packagecontrol.io/packages/Elm%20Language%20Support
MIT License
122 stars 27 forks source link

Amend grammar to accept Elm 0.17 module declaration #101

Open ThomasWeiser opened 8 years ago

ThomasWeiser commented 8 years ago

Grammar now accepts both syntax variations:

Elm 0.16: module Queue (..) where Elm 0.17: module Queue exposing (..)

eeue56 commented 8 years ago

@deadfoxygrandpa ping

esad commented 8 years ago

Would adding support for "port module" and "effects module" be too much effort?

ThomasWeiser commented 8 years ago

Added a commit with:

Example of valid module declarations in 0.17:

effect module WebSocket where { command = MyCmd, subscription = MySub } exposing (
    send
  , listen
  , keepAlive
  )
port module Spelling exposing (..)
module WebSocket.LowLevel exposing ( WebSocket
  , open, Settings
  , send, close, closeWith
  , bytesQueued
  , BadOpen(..), BadClose(..), BadSend(..)
  )
module Main 

0.16:

module Config ( title ) where

(Please note, that at the time of this writing GitHub highlights the code blocks above according to 0.16 rules. This repo is the source of GitHub's Elm rules. So merging this PR should change also the highlighting here.)

glenjamin commented 8 years ago

In case anyone wants to quickly apply this manually, you can try the following - which worked for me on OS X. You'll need to adjust the paths as appropriate

cd /Users/glen/Library/Application\ Support/Sublime\ Text\ 3/Packages/Elm\ Language\ Support
curl https://github.com/deadfoxygrandpa/Elm.tmLanguage/pull/101.patch -L | patch -p1
igregson commented 8 years ago

For @glenjamin's approach on Ubuntu, the directory to run the curl command from (at least for my specific st3 install):

~/.config/sublime-text-3/Packages/Elm\ Language\ Support
rtfeldman commented 8 years ago

@deadfoxygrandpa this is a huge community pain point, and Sublime is now the only editor not updated for 0.17's breaking syntax changes...are you still up for maintaining this repo?

esad commented 8 years ago

@deadfoxygrandpa Please consider moving this project to elm-community organization. What do you think @rtfeldman, would having support for major editors under elm-community make sense?

eeue56 commented 8 years ago

This has already been moved to elm-community. Deadfoxygrandpa has been unresponsive for about a month now

On Monday, May 30, 2016, Esad Hajdarevic notifications@github.com wrote:

@deadfoxygrandpa https://github.com/deadfoxygrandpa Please consider moving this project to elm-community organization. What do you think @rtfeldman https://github.com/rtfeldman, would having support for major editors under elm-community make sense?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/deadfoxygrandpa/Elm.tmLanguage/pull/101#issuecomment-222474749, or mute the thread https://github.com/notifications/unsubscribe/ABFh_hNyPay6QXnO5qawdyJbFVwSdsmhks5qGs1MgaJpZM4IUQr9 .

Cheers, Noah

noah@astraldynamics.co.uk Astral Dynamics Cyf Festri Cefn Y Waen, Deiniolen, Caernarfon, Gwynedd LL55 3NB Company number 07726862 Registered in England and Wales

esad commented 8 years ago

@eeue56 Should we make PR to https://github.com/wbond/package_control_channel to have the default package switch to the new repo?

ThomasWeiser commented 8 years ago

Just opened a PR to adopt the package by elm-community.

rtfeldman commented 8 years ago

@ThomasWeiser probably makes sense to do the same for linguist, to update GH, yeah?

ThomasWeiser commented 8 years ago

Opened PR at github/linguist.

ThomasWeiser commented 8 years ago

Status report: