Closed texastoland closed 9 years ago
Tried it out, got this in the console:
Some new packages are needed. Here is the upgrade plan.
Install:
elm-lang/core 2.1.0
Do you approve of this plan? (y/n) elm-make: <stdin>: hGetLine: end of file
[Finished in 1.0s with exit code 1]
[shell_cmd: elm-make]
[dir: /Users/rtfeldman/code/elm-core/src]
[path: /usr/bin:/bin:/usr/sbin:/sbin]
I've seen the hGetLine: end of file
error before (it's a Haskell thing), and we've worked around it by setting the LANG
env var. I tried doing that in the build config...
{
"env": {
"LANG": "en_US.UTF-8"
},
"shell_cmd": "elm-make"
}
...but this time it didn't help.
Anyway, the error was happening because the file I was editing (Maybe.elm
in core
) happened to be in the src/
directory instead of the project root. elm-make
needs to run in whatever directory elm-package.json
lives in, so I hacked around it by doing this:
{
"working_dir": "../",
"shell_cmd": "elm-make"
}
...although naturally that's not a scalable solution. :smile:
At that point the build ran and I saw the output in the console, which was pretty sweet!
I have Highlight Build Errors installed, but didn't see any inline. (I also tried uninstalling/reinstalling Highlight Build Errors, uninstalling/reinstalling elm-sublime
, and restarting Sublime Text 3, but still no highlighting.)
Awesome progress @dnalot! :smiley:
Same deal with SublimeREPL: I have it installed, but don't see Elm integrations.
Also, for reference, this is the version I had installed:
Mind reporting each in my fork?
src
folder: Looking now!Status:
hGetLine
issue. I'm supposed to be passing the --yes
flag? I meant to account for it if you can raise the issue.elm-make
prepending JSON with a message. I have a solution for that. Reported upstream elm-lang/elm-make#38. Issue in mine wouldn't hurt.I just remembered this, and so I don't forget it I'll write it down. the --output /dev/null
trick doesn't work on Windows, but I just tried --output NUL
and that seems to work, so we should probably do it that way on Windows.
I already did it. Don't merge yet though! I just rebased.
@rtfeldman All issues should be fixed 🙏
Is it possible to hyperlink from errors in the console to the code?
That would be very nice, if possible!
On Thu, Aug 6, 2015, 12:05 PM Pete Vilter notifications@github.com wrote:
Is it possible to hyperlink from errors in the console to the code?
— Reply to this email directly or view it on GitHub https://github.com/deadfoxygrandpa/Elm.tmLanguage/pull/25#issuecomment-128475651 .
Yes but I'm still evaluating how to do it with the least amount of code. Basically it's completely custom navigation. Report it in either repo and I'll tag it as a feature!
Reported in your fork (issue 3)
@deadfoxygrandpa This one's ready to merge. I'll open a separate PR for a ST3 error in existing code. Also looking into #28 if you can take #29?
OK, I'll merge it in. Thanks a lot for all this work.
This is the big one. I'll just list features:
Run
additionally builds output to an intelligent path.elm-package.json
. Keys not documented? No fear! There's a UI labeledElm Build System
in the Command Palette. It only requires a valid config in any ancestor directory of the edited file.