search

deadfoxygrandpa / Elm.tmLanguage

Elm language syntax highlighting and tool integration for ST2/3
https://packagecontrol.io/packages/Elm%20Language%20Support
MIT License
122 stars 27 forks source link

Fix column num integration w/ HighlightBuildErrors #94

Closed msjyoo closed 8 years ago

msjyoo commented 8 years ago

Hello,

This PR fixes #93 by capturing the build error message.

Now, the caption displayed under the build error highlight is not the "column number" but the actual build error which is always the first line of the error message.

Before, the column information wasn't compatible with HBE as HBE will only use the column information if the capture group length is >= 4.

screenshot from 2016-02-25 17 34 24

TODO: It seems that Sublime Text 3's popup allows for HTML inside the popups, so multiline error message popups are possible. I'll add a fifth capture group with the additional messages in this PR.

Status: Complete, ready to be merged!

msjyoo commented 8 years ago

For the actual bug, see the bug report which has a screenshot attached.

msjyoo commented 8 years ago

Okay, ready to be merged!

Actually, adding a 5th capture group is a bad idea. Please do not merge yet :/

Okay, (really) ready to be merged! Squashed commits.

deadfoxygrandpa commented 8 years ago

OK, thanks!

msjyoo commented 8 years ago

@deadfoxygrandpa Hello, just wondering if you can tag a new release with this patch in it?