Remove use of List.maximum.

[laszlopandy]

In master of elm-lang/core the type of List.maximum has changed (it now returns a Maybe). This change will allow the core tests to run again, and prevent upgrading problems for everyone else when elm-lang/core 2.0 comes out.

[deadfoxygrandpa]

Thanks.

[laszlopandy]

Thanks for merging. If you haven't done it already, can you punish a new version on elm package? Then we can bump the version in elm-core and the tests will be green again.

On Tuesday, January 20, 2015, Alex Neslusan notifications@github.com wrote:

Thanks.

— Reply to this email directly or view it on GitHub https://github.com/deadfoxygrandpa/Elm-Test/pull/15#issuecomment-70643209 .

[deadfoxygrandpa]

Already published.

On Tue, Jan 20, 2015 at 9:08 PM, Laszlo Pandy notifications@github.com wrote:

Thanks for merging. If you haven't done it already, can you punish a new version on elm package? Then we can bump the version in elm-core and the tests will be green again.

On Tuesday, January 20, 2015, Alex Neslusan notifications@github.com wrote:

Thanks.

— Reply to this email directly or view it on GitHub < https://github.com/deadfoxygrandpa/Elm-Test/pull/15#issuecomment-70643209>

.

— Reply to this email directly or view it on GitHub https://github.com/deadfoxygrandpa/Elm-Test/pull/15#issuecomment-70650458 .

[deadfoxygrandpa]

And actually, you don't need to bump anything on core because this was only a patch version of Elm-Test. From 1.0.2 to 1.0.3, and the version bounds in core just say 1.0.0 <= v < 2.0.0, so if you simply rerun the existing failed tests, they should now pass. You can do this retroactively on commits that have already failed without changing anything in core itself.

On Tue, Jan 20, 2015 at 9:30 PM, Alex Neslusan deadfoxygrandpa@gmail.com wrote:

Already published.

On Tue, Jan 20, 2015 at 9:08 PM, Laszlo Pandy notifications@github.com wrote:

Thanks for merging. If you haven't done it already, can you punish a new version on elm package? Then we can bump the version in elm-core and the tests will be green again.

On Tuesday, January 20, 2015, Alex Neslusan notifications@github.com wrote:

Thanks.

— Reply to this email directly or view it on GitHub < https://github.com/deadfoxygrandpa/Elm-Test/pull/15#issuecomment-70643209>

.

— Reply to this email directly or view it on GitHub https://github.com/deadfoxygrandpa/Elm-Test/pull/15#issuecomment-70650458 .

[laszlopandy]

Ok great. But I'll ask evan to move the lower bound to 1.0.3 anyway.

On Tue, Jan 20, 2015 at 2:32 PM, Alex Neslusan notifications@github.com wrote:

And actually, you don't need to bump anything on core because this was only a patch version of Elm-Test. From 1.0.2 to 1.0.3, and the version bounds in core just say 1.0.0 <= v < 2.0.0, so if you simply rerun the existing failed tests, they should now pass. You can do this retroactively on commits that have already failed without changing anything in core itself.

On Tue, Jan 20, 2015 at 9:30 PM, Alex Neslusan deadfoxygrandpa@gmail.com

wrote:

Already published.

On Tue, Jan 20, 2015 at 9:08 PM, Laszlo Pandy notifications@github.com

wrote:

Thanks for merging. If you haven't done it already, can you punish a new version on elm package? Then we can bump the version in elm-core and the tests will be green again.

On Tuesday, January 20, 2015, Alex Neslusan notifications@github.com wrote:

Thanks.

— Reply to this email directly or view it on GitHub <

https://github.com/deadfoxygrandpa/Elm-Test/pull/15#issuecomment-70643209>

.

— Reply to this email directly or view it on GitHub < https://github.com/deadfoxygrandpa/Elm-Test/pull/15#issuecomment-70650458>

.

— Reply to this email directly or view it on GitHub https://github.com/deadfoxygrandpa/Elm-Test/pull/15#issuecomment-70653171 .

[laszlopandy]

https://github.com/elm-lang/core/pull/121