deadlinks / cargo-deadlinks

Cargo subcommand for checking your documentation for broken links
Apache License 2.0
149 stars 16 forks source link

rustdoc links to the wrong method anchor in Rust 1.53.0 #147

Closed laysakura closed 3 years ago

laysakura commented 3 years ago

Errors

https://github.com/laysakura/serde-encrypt/runs/2911263090

 Documenting serde-encrypt v0.6.0 (/home/runner/work/serde-encrypt/serde-encrypt/serde-encrypt)
    Finished dev [unoptimized + debuginfo] target(s) in 37.05s
Found invalid urls in error/struct.Error.html:
    Fragment #tymethod.vzip at error/struct.Error.html does not exist!
Found invalid urls in error/enum.ErrorKind.html:
    Fragment #tymethod.vzip at error/enum.ErrorKind.html does not exist!
Found invalid urls in key/key_pair/public_key/struct.ReceiverPublicKey.html:
    Fragment #tymethod.vzip at key/key_pair/public_key/struct.ReceiverPublicKey.html does not exist!
...

How to reproduce

docker run -it --rm  rust:1.53 bash
git clone https://github.com/laysakura/serde-encrypt.git
cd serde-encrypt/
git checkout e6eebbe8e54a60a3aa34084a3f6b35267cfde713

cargo install cargo-deadlinks

rustup override set 1.53.0
cargo deadlinks  # => error

rustup override set 1.52.1
cargo deadlinks  # => ok
jyn514 commented 3 years ago

This is an upstream bug. In impl<V: Multilane, T> VZip for T, the function vzip links to #tymethod.vzip, but the proper link is #method.vzip. image

jyn514 commented 3 years ago

Closing in favor of https://github.com/rust-lang/rust/issues/86620.