deadlock-wiki / deadbot

Repository to handle any scripting and automation for the Deadlock Wiki
MIT License
13 stars 6 forks source link

Feature/changelog tags & versioning prep #84

Closed Surxe closed 6 days ago

Surxe commented 3 weeks ago

Main changes

Other changes

The {{PageRef}} has an initial version but is still very subject to change as it is planned to prioritize svg icons that are both light and dark theme compatible, which is waiting on dark theme release.

I added complete documentation on how I expect the Changelog editing process (after uploader) to go at [[Module:Changelog/doc]], as well as parsing for the list of Changelog Date pages displayed on [[Changelog Dates]], and some initial (front-facing) preparations at [[Changelog Tags]]

Surxe commented 3 weeks ago

Ready for review. There are 300+ files in the filediff because of the storage change. Instead, to see the changes, run main.sh with Changelog on, then view output-data/changelogs directory, fetch_changelogs. and parse_changelogs

Surxe commented 2 weeks ago

Really great work! How we plan on deploying this? As we will have to make sure any existing contributions aren't just paved over (assuming they aren't handled by the parsed logs)

Great question! Essentially, I am just going to need to spend a weekend merging the parsed data from here and the special formats that are done from the existing update pages. It will mostly be stuff like Shadow Transformation being nicknamed to Shadow Explosion as Valve renamed it. I have the main cases that require human-intervention documented on [[Module:Changelogs]] too!

hassayag commented 2 weeks ago

Closed so i can reopen and trigger the deadlock-data PR 🤞

hassayag commented 2 weeks ago

Okay this is the one

Surxe commented 2 weeks ago

Summary of changes since last review:

Surxe commented 2 weeks ago

Today's changes

Surxe commented 2 weeks ago

@hassayag it won’t let me reply to your comment at https://github.com/deadlock-wiki/deadbot/pull/84#discussion_r1825075373 so I’ll reply here

The optimal (but would never be agreed upon) route is to have ability pages at /Ability/<abilityname>, hero pages at /Hero/<heroname>, etc. Instead, when we spot dupes during the uploader script, we will have it create the pages as /<entityname> (Ability) and /<entityname> (Item). I'm actually leaning towards no parentheses simply for better localization support, so /<entityname> Ability

It would also create an ambiguation page at /<entityname>

Surxe commented 1 week ago

Summary of changes since last review:

  1. More tags added

    • Base Guardian
    • Sapphire Hand / Amber Hand
    • Cosmic Veil
    • Crate
    • Powerup
    • Breakable (now parent to many previously added tags too)
    • Sandbox
    • Shop
    • Minimap (merged into Map tag)
    • Parry
    • Light Melee, Heavy Melee, Melee
    • Idol (merged into Urn)
    • Pause
    • Sinner's Sacrifice (Vault)
    • Urn tag renamed to Soul Urn
    • Flex Slot
    • Hero lab related changes now use tag HeroLab <heroname>
  2. Hero lab entries now added manually via input-data rather than output-data. Created a readme for this process as well, as it will be manual unless Valve uploads hero lab notes to the forums, or some image recognition is applied to read the ones from in game. Cleaned up some old hero lab specific files that were meant to be removed earlier.

  3. Tag child/parent hierarchy scripted into dictionary format at tag_tree.json, uploaded to [[Data:Changelog Tag Tree.json]], and used by [[Module:Changelog]] for use on [[Template:Changelogs Navbox]] (though admittedly its not actually a navbox yet, maybe som1 will have ideas for it down the line)

Surxe commented 1 week ago

Changes since last review:

Specific tag related changes:

Surxe commented 6 days ago

Changes since last review: