deadlockempire / deadlockempire.github.io

The Deadlock Empire: Slay dragons, learn concurrency!
https://deadlockempire.github.io
GNU General Public License v2.0
977 stars 45 forks source link

is this code in `ui.js` reachable? #53

Open jpluimers opened 7 years ago

jpluimers commented 7 years ago

I think the ToString(...) function in variables.js already covers the below cases in ui.js so they can go:

            if (type.name.indexOf("Semaphore") != -1) {
                valueRepr = 'SemaphoreSlim [count: ' + variable.value + ']';
            }
            else if (type.name.indexOf("Queue") != -1) {
                valueRepr = 'Queue [element count: ' + variable.value + ']';
            }
Soothsilver commented 7 years ago

I think you are right.

Soothsilver commented 7 years ago

I will update the master branch to reflect your changes when I get to a computer with git.