deadpixi / sam

An updated version of the sam text editor.
Other
436 stars 47 forks source link

RFE/bug: unbound Ctrl-<x> keys should do nothing #31

Closed siebenmann closed 8 years ago

siebenmann commented 8 years ago

At the moment, sam interprets an unbound Ctrl- key as the same as . This is not traditional sam behavior (it inserts the Ctrl character) and is likely surprising. If one is going to change the traditional sam behavior, I think a better and less surprising default is to do nothing. People holding down Ctrl presumably expect it to do something different than the regular character, after all.

In a sam environment with an increasing number of Ctrl keys bound to do things, doing nothing by default also has the benefit that if you mis-type a Ctrl key (you aim for Ctrl-y, say, but get Ctrl-t by accident), you don't destroy the current selection by replacing it with whatever normal character you just typed.

deadpixi commented 8 years ago

@siebenmann Please check out the new master. Unbound control keys are ignored by default. Please close this issue if you consider this solved. Thanks.

siebenmann commented 8 years ago

Your change solves this. Thanks.