search

deadsy / sdfx

A simple CAD package using signed distance functions
MIT License
518 stars 52 forks source link

Render to triangles #74

Closed Megidd closed 6 months ago

Megidd commented 11 months ago

Reproduce

This PR tries to reproduce and debug a problem. The problem is that render.ToSTL() works fine. However, render.ToTriangles() is problematic. This problem is just introduced recently.

Megidd commented 11 months ago

The last commit fixes the problem.

Test

The output STL files are as expected:

2023-08-20 15_23_35-Window

2023-08-20 15_25_05-Window

Megidd commented 7 months ago

@deadsy 🙂 I was wondering if we can merge this PR. It's a simple and straightforward fix. It would save me some hassle. Thanks.

deadsy commented 7 months ago

Yes - give me a few days. I'm travelling at the moment and don't have time to immediately do it. -jasonh

On Sun, Dec 10, 2023 at 9:50 PM Megidd @.***> wrote:

@deadsy https://github.com/deadsy 🙂 I was wondering if we can merge this PR. It's a simple and straightforward fix. It would save me some hassle. Thanks.

— Reply to this email directly, view it on GitHub https://github.com/deadsy/sdfx/pull/74#issuecomment-1848927839, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYKH2M3Y4UG5ZKEHD2BCETYIWHXVAVCNFSM6AAAAAA3XBT5UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYHEZDOOBTHE . You are receiving this because you were mentioned.Message ID: @.***>