search

deadtrickster / prometheus-phoenix

Prometheus.io Phoenix instrumenter
71 stars 20 forks source link

New telemetry handler for phoenix 1.5+ projects #17

Open nurugger07 opened 4 years ago

nurugger07 commented 4 years ago

Greetings @deadtrickster!

I hope all is well. I have created a project called prometheus-phx that handles the telemetry changes in phoenix 1.5. I would be happy to contribute those changes back to this project but they would be breaking changes and require a major version bump. I'm not sure what your preference would be moving forward. Do you still want to continue maintaining this project? Would you want to transfer the project? Looking forward to hearing from you :)

For those interested here is a link to the new project: https://github.com/theblitzapp/prometheus-phx

It's not a hex package yet because I'm waiting the preferred direction from deadtrickster

deadtrickster commented 4 years ago

Yes, I would gladly accept contribution

oohnoitz commented 3 years ago

Would love to see this released in some form. Not the maintainer, but a major version bump with some notes on which version of the package is compatible with which version of Phoenix Framework should be enough?

deadtrickster commented 3 years ago

yes of course that would be enough

davidkovsky commented 3 years ago

@nurugger07 are you still working on this? I would love to see your changes merged into this library as well.

deadtrickster commented 3 years ago

@nurugger07 maybe we can help you somehow?

astjohn commented 3 years ago

FWIW, @nurugger07's repo works well in production so far and it's likely the adjustments just need to be copied over if he's preoccupied.

nurugger07 commented 3 years ago

Sorry, things have been a bit crazy lately but I'll get this wrapped up this week

nurugger07 commented 3 years ago

Got a WIP PR up so that @deadtrickster could begin the review process. Still need to update docs and add some additional functionality

smn commented 3 years ago

@nurugger07 looking at your implementation for some of our use cases, what help is required to get this merged in?

djschilling commented 3 years ago

@nurugger07 i am also waiting for this change