Phoenix 1.3 compatible?

deadtrickster / prometheus-phoenix

Prometheus.io Phoenix instrumenter

71 stars 20 forks source link

Phoenix 1.3 compatible? #3

Closed gaynetdinov closed 7 years ago

gaynetdinov commented 7 years ago

Currently phoenix dependency is locked on 1.2 branch. Is promeheus-phoenix compatible with phoenix 1.3?

deadtrickster commented 7 years ago

AFAIK instrumentation API hasn't changed. I'm still waiting for stable release. Are you using it already?

gaynetdinov commented 7 years ago

Kind of, I started to do the upgrade for one of our projects. Today I tested it on staging and it seems everything is okay, graphs are still there. I had to put override: true for phoenix dependency.

deadtrickster commented 7 years ago

Just pushed new version. Also added view instrumentation.