deadtrickster / prometheus.erl

Prometheus.io client in Erlang
MIT License
341 stars 117 forks source link

Added GH Action #123

Closed vkatsuba closed 3 years ago

vkatsuba commented 3 years ago

Purposes of changes:

GH Action Result: https://github.com/vkatsuba/prometheus.erl/actions/runs/788619303

deadtrickster commented 3 years ago

Great! could you please include elvis too?

vkatsuba commented 3 years ago

could you please include elvis too?

Done. GH Action Result: https://github.com/vkatsuba/prometheus.erl/runs/2447366977

deadtrickster commented 3 years ago

I just noticed a few changed unrelated to GH actions: src/metrics/prometheus_quantile_summary.erl test/eunit/collectors/vm/prometheus_vm_dist_collector_tests.erl

would be great to have them in a separate MR with short description, so I can proceed with this MR. Thanks!

vkatsuba commented 3 years ago

I just noticed a few changed unrelated to GH actions:

src/metrics/prometheus_quantile_summary.erl

test/eunit/collectors/vm/prometheus_vm_dist_collector_tests.erl

would be great to have them in a separate MR with short description, so I can proceed with this MR. Thanks!

The changes is related to dialyzer warnings. The dialyzer is a part of checking in GH Actions. I can remove it but I will also need to remove dialyzer call. Just for notes. The same about running tests in container, without those changes some tests will failed - I was provide this info in description. In other words all changes in current PR is related to GH actions and for tests/checking passing in containers.

vkatsuba commented 3 years ago

@deadtrickster I was divided to separate commits with short description. As I wrote above, they all refer to the current PR. So, please take a look if this approach with dividing commits is suite for you.