search

deadtrickster / prometheus.erl

Prometheus.io client in Erlang
MIT License
341 stars 117 forks source link

Quantile summary dializer problems #127

Closed deadtrickster closed 3 years ago

deadtrickster commented 3 years ago 
Line 307: The created fun has no local return
Line 346: The created fun has no local return
Line 487: Function quantile_merge/2 has no local return
Line 491: Record construction #quantile_estimator{samples_count::number(),data_count::'undefined',inserts_since_compression::'undefined',data::[#group{v::number(),g::number(),delta::number(),rank::number()}],invariant::fun()} violates the declared type of field data_count::number() and inserts_since_compression::number()

interestingly OTP 24 dialyzer just crushes on this.

temp remedy is 

-dialyzer({nowarn_function, quantile_merge/2}).
-dialyzer({no_return, [values/2, collect_metrics/2]}).

cc @hairyhum