Move export prometheus_text_format:escape_label_value outside of TEST def

deadtrickster / prometheus.erl

Prometheus.io client in Erlang

MIT License

341 stars 117 forks source link

Move export prometheus_text_format:escape_label_value outside of TEST def #158

Closed aaron-seo closed 10 months ago

aaron-seo commented 11 months ago

prometheus_text_format:escape_label_value is a useful helper function that users can benefit from using without having to duplicate the function in their code.

Namely, it can be used to escape prometheus core metric label values -- based on issue rabbitmq/rabbitmq-server#9648 and relevant PR/review from rabbitmq/rabbitmq-server#9656

michaelklishin commented 11 months ago

@ikvmw you may have to explicitly approve workflow runs for this PR as it is from/by a first-time contributor

aaron-seo commented 11 months ago

May need to be merged manually even after approval, due to the job continuous-integration/travis-ci Expected — Waiting for status to be reported stalling. @ikvmw @deadtrickster Thanks in advance :)

aaron-seo commented 11 months ago

Just bumping this for merge, if there are other tasks needed for the process, please feel free to let me know, thanks @deadtrickster @ikvmw