search

deadtrickster / prometheus.erl

Prometheus.io client in Erlang
MIT License
341 stars 117 forks source link

Optimise text_format:escape_label_value #160

Closed gomoripeti closed 10 months ago

gomoripeti commented 11 months ago

Don't create a new binary if there is no special character to escape.

This PR is based on https://github.com/deadtrickster/prometheus.erl/pull/158 to preserve attribution of the author of that change.

deadtrickster commented 10 months ago

conflict :-(

gomoripeti commented 10 months ago

rebased to resolve the conflict

ikavgo commented 10 months ago

Merging is blocked The base branch requires all commits to be signed. :man_shrugging:

gomoripeti commented 10 months ago

o wow, I have to "Learn more about singing commits" and get back to you

gomoripeti commented 10 months ago

pushed a signed commit now

deadtrickster commented 10 months ago

Great! Thank you

gomoripeti commented 10 months ago

would you mind tagging a new version including this change, so it can be included in RabbitMQ (used by this PR https://github.com/rabbitmq/rabbitmq-server/pull/9656)