deadtrickster / prometheus.erl

Prometheus.io client in Erlang
MIT License
341 stars 117 forks source link

Use upstream `quantile_estimator`? #163

Open kivra-pauoli opened 7 months ago

kivra-pauoli commented 7 months ago

👋, @deadtrickster.

First of all, great work on this lib.

Recently, while compiling with OTP 26, we started seeing some quantile_estimator -related issues:

Since https://github.com/deadtrickster/quantile_estimator is an (outdated) fork of https://github.com/odo/quantile_estimator (and implements no novelty on top of it) I wonder if you'd be open to start using that version, instead of your fork?

Maybe @odo and you can even come to an agreement in sharing publishing rights for the lib. in Hex (it seems the one published there is the fork, not the upstream) and it'd help maintenance for us consumers, since:

Thanks for taking this into consideration.

kivra-pauoli commented 4 months ago

As per a more recent issue we faced, this would also solve using https://github.com/voltone/rebar3_sbom on quantile_estimator, pulled by this library, to identify the license as "MIT" instead of "N/A": https://github.com/odo/quantile_estimator/blob/master/src/quantile_estimator.app.src#L5.

Is there anything I can do to help move this process forward?

essen commented 4 months ago

@ikavgo

ikavgo commented 4 months ago

hello, how I add @odo to hex package?

kivra-pauoli commented 4 months ago

Lemme check. I've done this in the past, but don't remember the details by heart.

Edit

Using the hex plugin for rebar3:

rebar3 hex owner add -r <repo> <package> <username>

I'm not sure what the <username> is since I don't think it's possible to search Hex.pm by user. <package> should be quantile_estimator. <repo> I'm not sure it's the GitHub one or Hex.pm one.

Thanks for looking into this.

odo commented 3 months ago

Happy to share the rights and make the package more compatible