search

deadtrickster / prometheus.ex

Prometheus.io Elixir client
406 stars 68 forks source link

Prometheus.Erlang: Fix Kernel.Utils.defdelegate usage for Elixir 1.14 #47

Closed lanodan closed 10 months ago

lanodan commented 2 years ago

Elixir 1.14 changed Kernel.Utils.defdelegate/2 into Kernel.Utils.defdelegate_each/2

ulissesalmeida commented 2 years ago

Elixir v1.14 is officially released yesterday 🎉

This change would be way much more appreciate now 🙏🏽

pierot commented 1 year ago

Can this be merged? Would be great, thanks!

ulissesalmeida commented 1 year ago

I don't know if it helps, but we're using this commit in production for several weeks, all good 👍🏽

jrichocean commented 1 year ago

Branch works for me as well and also hoping this can be merged, Thank you!

gabrielpedepera commented 1 year ago

Really interested in this too. By, chance do you have some estimation to merge and release it? Also if there's something that I can help with, just let me know.

lanodan commented 1 year ago

Can I please not have yet another "Works For Me"?
It's nice to know but I think that point has been well proven by now.

alexandresw commented 1 year ago

Could this PR be merged and released in a new version, please?

imsoulfly commented 1 year ago

Any news on this one? @deadtrickster maybe? Thx!

mopp commented 1 year ago

@deadtrickster Hi! This PR is ready to merge. We've waited for prometheus.ex to support the newest Elixir because monitoring is the most important part of our operation on the Elixir application in production. 🙏 🙏 🙏

dustinrouillard commented 1 year ago

Still not merged, fr :/

Stratus3D commented 1 year ago

I don't need this anymore - I've migrated to telemetry and telemetry_metrics_prometheus_core.

mopp commented 1 year ago

@deadtrickster ping 🙏 🙏 🙏

mopp commented 1 year ago

@deadtrickster @ikvmw please merge 🙏 🙏 🙏 🙏 🙏 🙏 🙏

mopp commented 1 year ago

Elixir v1.15 is officially released yesterday 🎉

gerbal commented 1 year ago

@deadtrickster or @ikvmw Any update here?

mopp commented 1 year ago

@deadtrickster We are waiting to merge 😭 😭 😭

sorliem commented 11 months ago

Bump on this, would be great to merge... :pray:

epinault commented 10 months ago

just to add more nagging, can this be merge? the community is going to hurt unless we start forking (which is not really a good place to be either) @deadtrickster please? can you help? who else is a project owner here?

epinault commented 10 months ago

for those who need, I updated also the deps and merge the fix here for now https://github.com/podium/prometheus.ex as another option

deadtrickster commented 10 months ago

Sorry, I forgot 🤷‍♂️

deadtrickster commented 10 months ago

published package as well

sorliem commented 10 months ago

Thanks @deadtrickster !

epinault commented 10 months ago

thanks! @deadtrickster

mopp commented 10 months ago

Thanks @deadtrickster !

ulissesalmeida commented 10 months ago

Thank you @deadtrickster

ikavgo commented 10 months ago

:blush: