Be a good RabbitMQ 3.7.x plugin citizen: depend on the `rabbit` app

deadtrickster / prometheus_rabbitmq_exporter

Prometheus.io exporter as a RabbitMQ Managment Plugin plugin

MIT License

291 stars 72 forks source link

Be a good RabbitMQ 3.7.x plugin citizen: depend on the `rabbit` app #44

Closed michaelklishin closed 6 years ago

michaelklishin commented 6 years ago

Starting with 3.7.x plugins must depend on the rabbit app (see Breaking Changes: apparently I cannot link to a section, sorry) or else they won't appear in rabbitmq-plugins list output.

This is not an issue if the plugin is "pre-enabled" (was enabled previously or the node uses a generated enabled_plugins file) but it is a major problem for beginners.

deadtrickster commented 6 years ago

Hey, thanks for pointing out but I don't get what 'depend' means, I have rabbit listed there https://github.com/deadtrickster/prometheus_rabbitmq_exporter/blob/master/src/prometheus_rabbitmq_exporter.app.src#L9. Could you please elaborate.

michaelklishin commented 6 years ago

Oh, so there is a hand crafted .app.src file. Fair enough, sorry about the noise.