search

deajan / smartmontools-win

smartmontools for windows package providing automated / mass installation and email alert support out of the box for hard drive SMART functionality. Scriptable for unattended or GUI end user install.
GNU General Public License v2.0
51 stars 15 forks source link

Bug in smartd service detection #27

Closed maxdevaine closed 3 years ago

maxdevaine commented 5 years ago

Hi, if I manually uninstall smartd service (I tryeing silent uninstall your tool, but one window still popup), then uninstallation program give back :

"There is a smartd service is installed which does not seem to belong to smartmontools-win. Do you want to uninstall it ?"

I think problem is with this code "smartmontools for Windows includes.iss":

ShellExec('', ExpandConstant('{cmd}'), ExpandConstant('/C {sys}\sc.exe qc ' + srv + ' | findstr "BINARY_PATH_NAME" | findstr /C:"\\smartmontools for Windows\\"'), '', SW_HIDE, ewWaitUntilTerminated, resultcode);

You trying find english name, but Windows translate most of internal strings. So, in another language does not exist name "BINARY_PATH_NAME".

BTW, I would like to completly clear some PC, I do no want to stop using your tools. It is very nice and useful. Thanks for your work.

Max PS: I think I have now only one option to uinstall this program in silent mode, force remove all from directories and from registry via own batch file, or do you have any other idea?

deajan commented 3 years ago

Fixed, with only a 2 years delay ;(