Add fallback support to tcptraceroute

deajan / tcpping

tcpping script for smokeping that runs with newer linux traceroute binaries

GNU General Public License v3.0

127 stars 39 forks source link

Add fallback support to tcptraceroute #14

Closed dmascord closed 7 months ago

dmascord commented 3 years ago

If traceroute does not support the -M (method), then fall back to tcptraceroute

deajan commented 3 years ago

Looks good, what platform did you test it on ?

dmascord commented 3 years ago

Hi,

I am testing on Debian 10 host OS, and alpine linux docker image. I still have one scenario where tcptraceroute doesn't work, but traceroute -M tcp works... I don't understand yet :)

Cheers,

Damien

deajan commented 3 years ago

Okay, ping me when your PR is ready so I can test it broadly on BSD and other unixes.

dmascord commented 3 years ago

Hi,

It looks like my other use case is in relation to empty "TCP Options" being dropped by firewalls. The fix for tcptraceroute has been added in https://github.com/mct/tcptraceroute/pull/14

Cheers,

Damien

deajan commented 2 years ago

Are we still needing this PR ?