search

deakjahn / vscode-php-allfactor

Comprehensive PHP refactoring (Visual Studio Code)
https://marketplace.visualstudio.com/items?itemName=tramontana.php-allfactor
1 stars 0 forks source link

Items in menu of extracting a constant is duplicated #4

Closed AndreiOrmanji closed 1 year ago

AndreiOrmanji commented 1 year ago

image

deakjahn commented 1 year ago

That's actually misguiding. There are in fact two enclosing blocks there, an inner one and an outer one (at least this is the only way I can reproduce it). The question is whether we list all enclosing blocks, and if so, how to diferentiate them.

AndreiOrmanji commented 1 year ago

That's actually misguiding. There are in fact two enclosing blocks there, an inner one and an outer one (at least this is the only way I can reproduce it). The question is whether we list all enclosing blocks, and if so, how to diferentiate them.

Is it possible to show preview as for Rename ? If it is so, then you could use it to show how selecting each of variants will affect existing code.

deakjahn commented 1 year ago

Unfortunately, not. VS Code itself shows the preview, not the extension.

deakjahn commented 1 year ago

@AndreiOrmanji I'll experiment with adding a specifier in parentheses.

deakjahn commented 1 year ago

It will soon appear in the upcoming version 1.3.4. Thanks.