search

dealertrack / django-rest-framework-braces

Collection of utilities for working with django rest framework (DRF)
Other
72 stars 21 forks source link

DRF 3.14 removes NullBooleanField #35

Open jayvdb opened 2 years ago

jayvdb commented 2 years ago

All use now fails with

[   36s] ============================= test session starts ==============================
[   36s] platform linux -- Python 3.8.14, pytest-7.1.2, pluggy-1.0.0 -- /usr/bin/python3.8
[   36s] cachedir: .pytest_cache
[   36s] django: settings: tests.settings (from env)
[   36s] rootdir: /home/abuild/rpmbuild/BUILD/django-rest-framework-braces-0.3.4
[   36s] plugins: django-4.5.2
[   37s] collecting ... collected 40 items / 5 errors / 1 deselected / 39 selected
[   37s] 
[   37s] ==================================== ERRORS ====================================
[   37s] ___________ ERROR collecting drf_braces/tests/fields/test_custom.py ____________
[   37s] drf_braces/tests/fields/test_custom.py:9: in <module>
[   37s]     from ...fields.custom import (
[   37s] drf_braces/fields/__init__.py:3: in <module>
[   37s]     from ._fields import *  # noqa
[   37s] drf_braces/fields/_fields.py:45: in <module>
[   37s]     get_updated_fields(FIELDS, (EmptyStringFieldMixin, AllowBlankNullFieldMixin))
[   37s] drf_braces/fields/_fields.py:37: in get_updated_fields
[   37s]     fields = [globals()[i] for i in fields]
[   37s] drf_braces/fields/_fields.py:37: in <listcomp>
[   37s]     fields = [globals()[i] for i in fields]
[   37s] E   KeyError: 'NullBooleanField'
faroukbmiled commented 2 years ago

is there any solution to this?

umangsh commented 1 year ago

@danigm fix seems appropriate. How soon can it be merged? Still affecting builds.

umangsh commented 1 year ago

@miki725 for visibility. Are there any temporary workarounds?

Sergecodes commented 1 year ago

still facing this issue 1yr later ...