search

dealertrack / flake8-diff

Run flake8 across a set of changed files and filter out violations occurring only on the lines that were changed.
MIT License
20 stars 8 forks source link

Ability to ignore violations from selected directories/files #12

Closed miki725 closed 8 years ago

miki725 commented 9 years ago

If any auto-generated code is pushed to VCS (e.g. SQLAlchemy generated table definitions or South migrations), it will have many violations hence there should be a way to ignore those. Perhaps:

$ flake8-diff ... --ignore-files=path/to/ignore
gregarmer commented 9 years ago

I'm in two minds about this one - flake8-diff just executed flake8 which has its own methods of configuration (config file, # noqa tag etc). Shouldn't we just leverage that and only handle the filtering ?

miki725 commented 9 years ago

This makes sense. Then maybe allow an option to pass arguments to flake8 itself:

$ flake8-diff ... --flake8-options --exclude=...
jayvdb commented 8 years ago

--flake8-options has been added; should this be closed?

miki725 commented 8 years ago

yep. thanks @jayvdb for the reminder