Introduce Mercurial Support

dealertrack / flake8-diff

Run flake8 across a set of changed files and filter out violations occurring only on the lines that were changed.

MIT License

20 stars 8 forks source link

Introduce Mercurial Support #23

Closed netme closed 9 years ago

netme commented 9 years ago

Introduces basic Mercurial support based on extdiff mercurial extension.

How to test:

Install mercurial
Install flake8-diff
Enable the extdiff support in your local ~/.hgrc file:

[extensions]
extdiff =

Create a new mercurial repository using hg init <repository name>
Create an initial commit with a PEP8-compatible python file
Bookmark that commit using hg bookmark initial
Add few PEP8 incompatible changes to that file and commit them
Run flake8-diff --vcs=hg initial and check that the issues found by Flake8 are displayed.

miki725 commented 9 years ago

Cool. Thank you for the addition!

netme commented 9 years ago

@miki725 I did some improvements. Could you please check f70d26d...551f0b8 ?

miki725 commented 9 years ago

@netme looks great. just one Python3 issue

netme commented 9 years ago

@miki725 fixed

miki725 commented 9 years ago

@netme awesome. thank you!!!

@gregarmer leaving to you to review/merge

netme commented 9 years ago

@miki725 @gregarmer please also review your .travis.yml script. I'm not sure that it's worth to run it. It does pretty nothing.

miki725 commented 9 years ago

the reason for the travis is to set everything up for travis. the problem is that nobody had a chance to write any tests yet....

netme commented 9 years ago

@miki725 I see. Yes, tests are definitely missing. I've screwed up the system multiple times during this small extension implementation :)

netme commented 9 years ago

I've deployed this code on our Jenkins. Now it's a part of out CI process, looks like it works :)

netme commented 9 years ago

@gregarmer @miki725 should we merge my pull request?

gregarmer commented 9 years ago

@netme Thanks for the contribution! ... and apologies for the delay - I'll run through it asap.

gregarmer commented 9 years ago

The implementation looks good to me. At some point in the future, it would be nice to use the abc module to keep subclasses consistent and ensure all methods are defined.

netme commented 9 years ago

@gregarmer yes, can be an option, but I'll prefer to focus on test coverage first :)

netme commented 9 years ago

@gregarmer please check the latest commit

gregarmer commented 9 years ago

I'll merge as soon as the build completes, then I'll bump the version and push a new release to PyPI. Should be up in a couple hours.

netme commented 9 years ago

@gregarmer awesome, looking forward. Thanks again for reviewing it! I'll keep supporting the hg module since we have it in production now.

netme commented 9 years ago

@gregarmer it's green and ready to merge :tada:

gregarmer commented 9 years ago

@netme https://github.com/dealertrack/flake8-diff/releases/tag/v0.2.0

netme commented 9 years ago

@gregarmer thanks a lot. I will try to install it tomorrow.