search

dealertrend / wordpress-plugin-inventory-api

This is the new WordPress plugin for DealerTrend, Inc. It will interface with their Automotive Information System's API.
http://www.dealertrend.com
GNU General Public License v2.0
22 stars 6 forks source link

Manufactures with slashes like A/C cause URL parsing issues #39

Closed ghost closed 13 years ago

ghost commented 13 years ago

This is a long time issue from the original plugin.

A/C Cobra doen't work in clean URLs. But replacing the / with anything else fixes it. Sanitizing the make and models by replacing the / with something else would be a good fix for this problem.

Thanks.

Ryuske commented 13 years ago

Does changing it from / to %2F work? If it does then simple hex encode/decode would fix this issue, and anything similar that might come up down the road

ghost commented 13 years ago

Yes, %2F seems to work fine.

Ryuske commented 13 years ago

Fixed

ghost commented 13 years ago

This is strange. It's fixed on one site, but not on another site that uses the same inventory: http://mikezuk.orangeroomsoftware.com/inventory/ (works) http://california-motors.orangeroomsoftware.com/inventory/ (broken)

And where I really need it to work: http://www.myhotcars.com/inventory/

grok commented 13 years ago

We'll need to review the changes made in the branch that fixes this. Once it's incorporated into the mainline it should be consistent.