search

dealfonso / sapp

Simple and Agnostic PDF Document Parser in PHP - sign PDF docs using PHP
GNU Lesser General Public License v3.0
121 stars 32 forks source link

Support paths on certs array #51

Closed erikn69 closed 3 months ago

erikn69 commented 1 year ago

Would this be useful or unnecessary?

// this add support for this
$certArray =[
    'cert' => '/PATH/TO/MY/cert.pem',
    'pkey' => '/PATH/TO/MY/key.pem',
    //'extracerts' => '/PATH/TO/MY/extracerts.pem',
];
// Current
$certArray =[
    'cert' => file_get_contents('/PATH/TO/MY/cert.pem'),
    'pkey' => file_get_contents('/PATH/TO/MY/key.pem'),
    //'extracerts' => file_get_contents('/PATH/TO/MY/extracerts.pem'),
];
dealfonso commented 1 year ago

I don't think that it is needed. It would need just one pair of lines from the callee and avoids multiple types for parameters