dealfonso / sapp

Simple and Agnostic PDF Document Parser in PHP - sign PDF docs using PHP
GNU Lesser General Public License v3.0
121 stars 32 forks source link

Support timestamp #52

Closed erikn69 closed 6 months ago

erikn69 commented 1 year ago

Timestamp

dealfonso commented 1 year ago

Hi, what means "starting point"? Is it fully working or is it a work-in-progress?

erikn69 commented 1 year ago

Fully working, but LTV is pending

Also, the code is from https://github.com/dealfonso/sapp/issues/8#issuecomment-1059107230 and https://github.com/dealfonso/sapp/issues/8#issuecomment-1470039444, and there are probably shorter and better ways to do it, without needing to add phpseclib

Also i found this: https://github.com/tecnickcom/TCPDF/pull/617

hidasw commented 10 months ago

@erikn69

Fully working, but LTV is pending

Also, the code is from #8 (comment) and #8 (comment), and there are probably shorter and better ways to do it, without needing to add phpseclib

Also i found this: https://github.com/tecnickcom/TCPDF/pull/617

It's great. You right that its better if use self asn1 parser instead of phpseclib. I make simple code to parse and create asn1 https://github.com/hidasw/PhpASN1 , maybe you can improve that.

erikn69 commented 10 months ago

You right that its better if use self asn1 parser instead of phpseclib.

I think the same, but I have no experience, I just copied the code from the proposed examples

parallels999 commented 10 months ago

You right that its better if use self asn1 parser instead of phpseclib. I make simple code to parse and create asn1 https://github.com/hidasw/PhpASN1 , maybe you can improve that.

that would be great