search

dealii / code-gallery

A collection of codes based on deal.II contributed by deal.II users
Other
44 stars 54 forks source link

Removes a redundant edge from Nonlinear_PoroViscoelasticity tutorial dependencies #82

Closed krishnakumarg1984 closed 4 years ago

krishnakumarg1984 commented 4 years ago

Thanks for merging

jppelteret commented 4 years ago

Thanks for the fix. The original list better reflected how we went about developing this code, but the amendment makes sense in terms of what we're trying to show in the tutorial graph.

krishnakumarg1984 commented 4 years ago

I see. I didn't know about the background. I just thought that the tutorial flow-diagram looked a bit messy :)

jppelteret commented 4 years ago

And I haven't seen what the graph looked like before the patch was merged :-D As I said, it felt right to add all of those entries in when we documented the code, but I think that your changes are ultimately correct and in the spirit of what information we're trying to transmit to everyone.