dealy14 / ComplianceFactors.Website

This repository contains all source code for the ComplianceFactors SaaS web application.
0 stars 1 forks source link

Course player - incorrect display and window title/wrapping #17

Open ryanammons opened 11 years ago

ryanammons commented 11 years ago

The Course Player is not displaying the course properly and shows a Gray Screen for most courses but shows the top of other courses.

The course player should wrap around the content and not have any space around the course (neither on top, bottom, or side).

In addition, we already talked about this before, the Course Title should display in the Player Window Title Bar (Header).

ryanammons commented 11 years ago

Issue partially fixed. The course should display fully, top-to-bottom, and there should no longer be any space at the top or left.

ryanammons commented 11 years ago

I have uploaded a temporary fix whereby the course content should be centered with whitespace surrounding it, and the title of the course now appears in the browser title bar.

dealy14 commented 11 years ago

Ryan, the issue persists, see both screen shots… I’m using IE9

I’m again asking you to take advantage of my LMS Learningfox which launches courses properly…there has to be a way to utilize that code.

Can you please advise before Thursday as we have a meeting Friday.

Thanks

Dave

From: Ryan Ammons [mailto:notifications@github.com] Sent: Monday, August 19, 2013 12:14 AM To: dealy14/ComplianceFactors.Website Subject: Re: [ComplianceFactors.Website] Course player - incorrect display and window title/wrapping (#17)

I have uploaded a temporary fix whereby the course content should be centered with whitespace surrounding it, and the title of the course now appears in the browser title bar.

— Reply to this email directly or view it on GitHub https://github.com/dealy14/ComplianceFactors.Website/issues/17#issuecomment-22850125 . https://github.com/notifications/beacon/V9dFfaX8R2rXVv9z4ri-NtHXjZr4p7l004METgYcjFcUGEgq87VsZzWTttaWoudh.gif

ryanammons commented 11 years ago

Title I've added " - ComplianceFactors, Inc." to the end of the browser title of the course player as per Guy's request.

iFrame Layout in IE It is not possible to re-use the LearningFox course player code, as it targets HTML4/XHTML and we are targeting HTML5 in the CF player. Targeting HTML5 means using only iframes and not traditional frames, as they will no longer be supported in HTML5 client browsers.

After consulting with Charles, neither of us could replicate the content cut-off in IE9 that David is experiencing--except by forcing quirks mode for IE5. Still investigating...

ryanammons commented 11 years ago

I have thrown yet more suggested 'fixes' at the problem of IE9 switching to quirks mode (thereby rendering as if it were IE5), but I still can't reproduce exactly what David is experiencing. David, please test again, and make sure you've cleared your cache. Also, if possible, test from another machine with IE9.

dealy14 commented 10 years ago

Unable to launch Incomplete due to Launch button missing. Using Google Chrome, sending screen shot in email.