dealy14 / ComplianceFactors.Website

This repository contains all source code for the ComplianceFactors SaaS web application.
0 stars 1 forks source link

Launch button link: Domain for HACP Handler URL has to be generated dynamically #45

Open ryanammons opened 10 years ago

ryanammons commented 10 years ago

For example, the URL generated on line 233 in Employee\Course\lmcp-01.aspx.cs has a hardcoded URL (right now, compliancefactors.com.lavender.arvixe.com). However, the URL should be dynamically generated based on the domain on which execution occurs. Otherwise, when the server domain is not the same as the hardcoded value, the HACP API will never be reached by the course content.

addisondarrick commented 10 years ago

Hi Ryan,

This issue appears to be relatively easy to resolve. I’ll also check all places that has this hard-coded URL in the solution, then replace them using C# code such as Request.Url.Host to get the real URL. Let me know if you would like me to fix this issue.

Another question:

You had mentioned when the server domain is not the same as the hard-coded value, the HACP API will never be reached by the course content. – what does the highlightedportion mean? I want to know if you're using the hard-coded URL. What happen to the website (i.e. the Course Player portion)? Is there something wrong on website, becausewhen I launch a course, everything looks good even though we’re using the hard-coded URL.Thanks,Darrick AddisonSenior Solutions Architectdaddison@compliancefactors.com866-866-2175 [main]704-909-9874 [direct]888-798-0802 [eFax]addisondarrick [Skype] ComplianceFactors, Inc.Hub Tower699 Walnut Street4th Floor / Suite 486Des Moines, IA 50309www.compliancefactors.comConfidentiality StatementThe information included in this email message is intended only for the party or parties to whom it is addressed and may contain confidential and/or privileged material from ComplianceFactors, Inc. Any review, retransmission, dissemination or any other use by party or parties other than the intended recipient(s) is strictly prohibited. If you are not an intended recipient, you are therefore not authorized to distribute this e-mail and its information without an explicit approval given above by a ComplianceFactors Official Representative.  

-------- Original Message -------- Subject: [ComplianceFactors.Website] Launch button link: Domain for HACP Handler URL has to be generated dynamically (#45) From: Ryan Ammons notifications@github.com Date: Sun, January 05, 2014 10:57 pm To: "dealy14/ComplianceFactors.Website" ComplianceFactors.Website@noreply.github.comFor example, the URL generated on line 233 in Employee\Course\lmcp-01.aspx.cs has a hardcoded URL (right now, compliancefactors.com.lavender.arvixe.com). However, the URL should be dynamically generated based on the domain on which execution occurs. Otherwise, when the server domain is not the same as the hardcoded value, the HACP API will never be reached by the course content. —Reply to this email directly or view it on GitHub.

addisondarrick commented 10 years ago

Darrick,

daddison@compliancefactors.com wrote:

This issue appears to be relatively easy to resolve. I’ll also check all places that has this hard-coded URL in the solution, then replace them using C# code such as Request.Url.Host to get the real URL. Let me know if you would like me to fix this issue.

Thanks for the suggestion! I'll use that solution for now, but it may eventually be necessary to get the handler uri from configuration. Don't know, though, so good enough for first release.

Another question:

You had mentioned when the server domain is not the same as the hard-coded value, the HACP API will never be reached by the course content. – what does the highlighted portion mean?

There are two forms the AICC API takes. One is via JS and AJAX (aka SCORM) and the other is via HTTP POST (aka AICC HACP). The course itself decides which method of communication to use, not our software. Currently the only courses we're testing are those using the JS/AJAX API--so those courses will work just fine. It only becomes a problem if a course decides to use the HACP method.

I want to know if you're using the hard-coded URL. What happen to the website (i.e. the Course Player portion)? Is there something wrong on website, because when I launch a course, everything looks good even though we’re using the hard-coded URL.

Again, it's because the courses tested are not opting for the HACP API. If they did, we'd see some problems.

-Ryan

Sent from my Android phone with K-9 Mail. Please excuse my brevity.