search

dealy14 / LearningFox-LMS

0 stars 0 forks source link

Message Board 'threads' link generation bug #65

Closed ryanammons closed 12 years ago

ryanammons commented 12 years ago

In mboard.php, line 314 sets $text = "<?php echo $sid; ?>";. However, this variable does not appear to be used. Rather, on line 324, the generation of the link to the particular thread is incorrectly coded so as to output a php script block as a literal:

$threads[$i] .= "<!--s $count--><ul><li><a href=\"index.php?count=".$count.
    "&section=msg&sid=<?php echo \$sid; ?>\">$subject</a> - <b>$name</b> <i>$date</i>\n";

Note <?php echo \$sid; ?> in the above code.

This does not appear to inhibit functionality, but it certainly is incorrect--and it creates malformed (but recoverable) links.

jstuckle commented 12 years ago

This is a duplicate of Issue #58. I thought this was an error also, but it is correct. The string is stored in a file and used to generate the run time list with the sid.