dean-krueger / NTR-Project

A collection of files associated with the modeling of a Nuclear Thermal Rocket core in OpenMC as a final class project for NE506 at UW-Madison.
3 stars 0 forks source link

messed up on git, I think this fixes things #23

Closed dean-krueger closed 5 months ago

dean-krueger commented 5 months ago

I honestly do NOT know what I did wrong, but the rebase did not work. I think this fixes things, but honestly I'm not sure. I deleted the old PR and branch in an attempt to fix this. Needless to say I backed up all the work I did somewhere else on my computer in case this DIDN'T fix things, but idk. I do no know what the issues with the merge are, or how to get around those. Hoping you have some idea.

This PR closes #12 This PR closes #13 This PR closes #15

I really hope this works...

Edgar-21 commented 5 months ago

add vacuum condition to outside and top and bottom

dean-krueger commented 5 months ago

Vacuum boundary conditions added to core_top, core_bottom, and outer_reflector_outer_boundary.

Edgar-21 commented 5 months ago

beautifull