search

deanWombourne / bitrise-step-diawi-upload

Upload an ipa/apk/zip to Diawi
MIT License
4 stars 4 forks source link

Are there plans to supply a password input? #4

Open kceb opened 4 years ago

kceb commented 4 years ago

Was wondering if there are plans to supply a password input to protect the app. I can try and see if I can help out & add it.

deanWombourne commented 4 years ago

Hi,

I think we already do that using the -p command line argument? Or have I misunderstood what you're asking for?

kceb commented 4 years ago

Sorry, I may be missing something, but where do we supply that -p when using the Bitrise step?

To clarify, I'm referring to the password that protects the app from being accessed by anybody with the URL.

deanWombourne commented 4 years ago

Ah, no, you're not missing anything! I've added a -p parameter to the node library this step wraps around, but it looks like we're not exposing the password setting in the bitwise plugin.

deanWombourne commented 4 years ago

Hey @kceb - can you take a look at this and let me know if that's what you wanted? https://github.com/deanWombourne/bitrise-step-diawi-upload/pull/5

Thanks!

kceb commented 4 years ago

@deanWombourne lgtm! thanks

deanWombourne commented 4 years ago

FYI: Step version 0.0.5 has been created and submitted to the steplib - should be available soon.

kceb commented 4 years ago

I'm not really familiar with bash scripting but it seems like eval caused the diawi_url=eval $cmd script to be run twice? It seems like it is generating a public upload url and a private upload url but only setting the $diawi_url to be the public one.

I did notice that the following might work better...

 diawi_url=`$cmd`

@deanWombourne thoughts?

Going to do a bit more manual testing with the backtick method instead.. apologies.