deanagit / swfobject

Automatically exported from code.google.com/p/swfobject
0 stars 0 forks source link

swfobject.embedSWF() does not support numeric version numbers #440

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
swfobject.embedSWF() throws a somewhat cryptic error if passed a numeric 
"minimum flash version" instead of a string.

That is, if

  swfobject.embedSWF("myContent.swf", "myContent", "300", "120", 
9,"expressInstall.swf", flashvars, params, attributes);

is used instead of

  swfobject.embedSWF("myContent.swf", "myContent", "300", "120", 
"9.0.0","expressInstall.swf", flashvars, params, attributes);

you get the error

  "rv.split is not a function"

in Firefox, and

  "Object 9 has no method 'split'"

in Chrome.

It would be helpful if a better warning was issued, or the number were cast 
to a string.

Original issue reported on code.google.com by ithinkihaveacat on 19 Feb 2010 at 12:51

GoogleCodeExporter commented 9 years ago
(The problem is with the function "hasPlayerVersion".)

Original comment by ithinkihaveacat on 19 Feb 2010 at 12:52

GoogleCodeExporter commented 9 years ago
Changing to an enhancement request.

Original comment by platelu...@gmail.com on 7 Nov 2010 at 9:28

GoogleCodeExporter commented 9 years ago

Original comment by platelu...@gmail.com on 7 Nov 2010 at 9:28

GoogleCodeExporter commented 9 years ago
ithinkihaveacat dont work :( http://fuckcopyright.net

Original comment by wordpresspremiumus@gmail.com on 23 Jan 2011 at 2:12

GoogleCodeExporter commented 9 years ago

Original comment by platelu...@gmail.com on 18 May 2011 at 6:35

GoogleCodeExporter commented 9 years ago
Set hasPlayerVersion to coerce number to string, if needed

Original comment by platelu...@gmail.com on 20 May 2011 at 11:02