deanhet / react-native-text-ticker

React Native Text Ticker/Marquee Component
MIT License
444 stars 75 forks source link

FlatList Compatibility + fix for setState on unmount issue #65

Closed curtismenmuir closed 4 years ago

curtismenmuir commented 4 years ago

Context

Change Description

deanhet commented 4 years ago

Good catch on the warning! Thanks for contributing and updating the docs too with the additional prop. I've tried your branch locally and everything seems to work like you said. Will merge and push out an update to the package now. 👍🏻

dimbslmh commented 4 years ago

@curtismenmuir

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

Please update the following components: TextMarquee

curtismenmuir commented 4 years ago

@dimbslmh Good catch, updated initialization to be set in constructor. See new PR: https://github.com/deanhet/react-native-text-ticker/pull/66