Closed curtismenmuir closed 4 years ago
Good catch on the warning! Thanks for contributing and updating the docs too with the additional prop. I've tried your branch locally and everything seems to work like you said. Will merge and push out an update to the package now. 👍🏻
@curtismenmuir
Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.
npx react-codemod rename-unsafe-lifecycles
in your project source folder.Please update the following components: TextMarquee
@dimbslmh Good catch, updated initialization to be set in constructor. See new PR: https://github.com/deanhet/react-native-text-ticker/pull/66
Context
'react-native-text-ticker: could not calculate metrics', 'nodehandle_not_found'
errors and the text-ticker was displaying weird behavior with text animations (The smallest list I seen this occur was ~30 items).Change Description
disabled
field so that the animation can be stopped. I have used this with the FlatList'sonViewableItemsChanged
callback so that any item which is not currently on screen will not animate.makeCancellable()
to allow promises to be cancelled incomponentWillUnmount()
. This will cleanup any unresolved promises to resolve the unmounted setState warning.resolve
andreject
have been nulled to help with GC. NOTE: This is not a perfect fix, but I believe that it is the best approach for now. More Details: https://github.com/reactjs/reactjs.org/pull/2562