search

deanhet / react-native-text-ticker

React Native Text Ticker/Marquee Component
MIT License
453 stars 75 forks source link

Improve RTL support #69

Closed MoKhajavi75 closed 4 years ago

MoKhajavi75 commented 4 years ago

Hey

There was a great effort in https://github.com/deanhet/react-native-text-ticker/pull/64 which adds RTL support but I guess there is a problem! Sometimes developer locks the app to LTR and handle the directions manually.

I think it's better to have it as a prop.

deanhet commented 4 years ago

Thanks for your contribution! I like this and it makes a lot of sense, it is however a breaking change for existing RTL users of this code.

How about defaulting RTL as it is right now but it can be overridden with a prop?

MoKhajavi75 commented 4 years ago

Oops :grin: You're right! And in that way, if the developer use I18nManager it works correctly!

Lemmie force push the changes...

MoKhajavi75 commented 4 years ago

@deanhet ping :heart:

deanhet commented 4 years ago

great stuff, will merge and push out a release now 👍