deanishe / alfred-booksearch

Search Goodreads.com from Alfred
MIT License
56 stars 0 forks source link

Add ability to view books inside of shelves #2

Closed nikitavoloboev closed 4 years ago

nikitavoloboev commented 4 years ago

Maybe I misunderstand and it's already implemented but from bkshlf

image

If I click on any of the shelves, workflow will quit and not actually go inside and retrieve contents of the list. I don't get any errors in console so I assume it's just not implemented.

deanishe commented 4 years ago

It should show the list of books.

nikitavoloboev commented 4 years ago

Get this in debugger when I press return on Read shelf (stripped tokens)

[17:44:30.794] Book Search[Script Filter] Processing complete
[17:44:30.806] Book Search[Script Filter] Passing output '' to Debug
[17:44:30.807] Book Search[Debug] .
/--------- RUN IN ---------\
query=""
variables={
  ACCESS_SECRET = ""
  ACCESS_TOKEN = ""
  action = "shelf"
  ACTION_ALT = "View Series"
  ACTION_DEFAULT = "Open Book Page"
  AW_SESSION_ID = "ZA3HQJ8B4DQTER5FLCNTUSDG"
  EXPORT_DETAILS = "false"
  last_action = "shelves"
  last_query = ""
  MAX_CACHE_AGE = "24h"
  passvars = "true"
  SHELF_ID = "50332488"
  SHELF_NAME = "read"
  SHELF_TITLE = "Read"
  USER_ID = "15768482"
  USER_NAME = "Nikita Voloboev"
}
\--------- RUN IN ---------/
[17:44:30.809] Book Search[Debug] Processing complete
[17:44:30.810] Book Search[Debug] Passing output '' to Run Script
[17:44:30.837] STDERR: Book Search[Run Script] 🍺
17:44:30 workflow.go:328: -------- Book Search/0.2.0 (AwGo/0.27.1) ---------
17:44:30 options.go:140: argv=[]string{}
17:44:30 options.go:201: query=""
17:44:30 workflow.go:405: ------------------- 2.978312ms -------------------
[17:44:30.838] Book Search[Run Script] Processing complete
[17:44:30.839] Book Search[Run Script] Passing output '' to Post Notification
[17:44:30.839] Book Search[Run Script] Passing output '' to Filter
[17:44:30.840] Book Search[Filter] Processing complete
[17:44:30.841] Book Search[Filter] Passing output '' to Hide Alfred
[17:44:30.878] Book Search[Run Script] Passing output '' to Debug
[17:44:30.879] Book Search[Debug] .
/--------- RUN OUT ---------\
query=""
variables={
  ACCESS_SECRET = ""
  ACCESS_TOKEN = ""
  action = "shelf"
  ACTION_ALT = "View Series"
  ACTION_DEFAULT = "Open Book Page"
  AW_SESSION_ID = "ZA3HQJ8B4DQTER5FLCNTUSDG"
  EXPORT_DETAILS = "false"
  last_action = "shelves"
  last_query = ""
  MAX_CACHE_AGE = "24h"
  passvars = "true"
  SHELF_ID = "50332488"
  SHELF_NAME = "read"
  SHELF_TITLE = "Read"
  USER_ID = "15768482"
  USER_NAME = "Nikita Voloboev"
}
\--------- RUN OUT ---------/
[17:44:30.881] Book Search[Debug] Processing complete
[17:44:30.881] Book Search[Debug] Passing output '' to Filter
[17:44:30.882] Book Search[Filter] Processing complete
[17:44:30.882] Book Search[Filter] Passing output '' to JSON Config
[17:44:30.883] Book Search[JSON Config] Processing complete
[17:44:30.884] Book Search[JSON Config] Passing output '' to Call External Trigger
[17:44:30.884] Book Search[External] Processing complete
[17:44:30.885] Book Search[External] Passing output '' to Script Filter
[17:44:30.886] Book Search[Script Filter] Queuing argument '(null)'

I can cmd+return to open the shelves in browser though. I'll try run the code and investigate.

Thanks for the nice update. ❤️

deanishe commented 4 years ago

The log looks fine. In the debugger, if you click on the “Script Filter” link in the last line, which element is highlighted?

nikitavoloboev commented 4 years ago
image

This one

deanishe commented 4 years ago

That's what it should be running. This looks like some weirdness on your machine with Alfred's window being hidden, like that time with Safari Assistant.

Just calling that External Trigger and Script Filter should show Alfred's window, and it shouldn't have actually closed in the first place.

nikitavoloboev commented 4 years ago

I think you are right. I opened issue in Alfred Forum, hope it gets solved with an update. Thanks.