When browsing folders, allow opening links too

[nikitavoloboev]

The bmf script filter allows you to search for folders and go inside folders.

However pressing enter on links inside the folders does nothing for me. I think it would be really useful to be able to open the links too.

[deanishe]

It's supposed to work that way: this is a bug. I missed it as I only ever open folders via bmf.

I'll look into it after work.

[deanishe]

Fixed in v0.4.4

[nikitavoloboev]

That was fast. Thank you.

[deanishe]

It turned out to be a pretty simple fix.

I created the bug when I removed UIDs from the bookmarks in "bookmark folder" mode (to stop Alfred sorting the results, so the Back to/Up to items are always at the top of the results). But the open folder/bookmark action requires the UID…

Fortunately, it was fairly simple to put back the UID variable (actually ALSF_UID, which the workflow needs) without re-adding the UID to Alfred items (which would have caused Alfred to sort the bookmarks).

[nikitavoloboev]

Thank you for the explanation.

But with new update I can't access the folders at all. Here is the log of me opening bmf and actioning on a folder:

\--------------------/
[2017-11-28 01:00:18][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 01:00:18][utility.filter] Processing output of 'utility.debug' with arg ''
[2017-11-28 01:00:18][utility.debug] .
/--- BROWSE FOLDER ---\
query=
variables={
    "ALSF_HISTORY_ENTRIES" = 1000;
    "ALSF_INCLUDE_BOOKMARKLETS" = 0;
    "ALSF_SEARCH_HOSTNAMES" = 1;
    "ALSF_TAB_CTRL" = "Close Tab";
    "ALSF_TAB_FN" = "Open in Private Window";
    "ALSF_TAB_OPT" = "Close Tabs to Left";
    "ALSF_TAB_SHIFT" = "Close Tabs to Right";
    "ALSF_UID" = "639C263B-B7DB-4B04-8074-ED3CEED943EE";
    "ALSF_URL_CTRL" = "Search in Bookmarks";
    "ALSF_URL_FN" = "Open in Private Window";
    "ALSF_URL_OPT" = "Open in Chrome";
    "ALSF_URL_SHIFT" = "";
    "AW_SESSION_ID" = N3HHMO6L0LJ7H6QDDQQG0CSW;
    action = browse;
}
\---------------------/
[2017-11-28 01:00:18][utility.debug] Processing output of 'output.callexternaltrigger' with arg ''
[2017-11-28 01:00:18][trigger.external] Processing output of 'utility.debug' with arg ''
[2017-11-28 01:00:18][utility.debug] .
/--- BROWSE FOLDER OUT ---\
query=
variables={
    "ALSF_HISTORY_ENTRIES" = 1000;
    "ALSF_INCLUDE_BOOKMARKLETS" = 0;
    "ALSF_SEARCH_HOSTNAMES" = 1;
    "ALSF_TAB_CTRL" = "Close Tab";
    "ALSF_TAB_FN" = "Open in Private Window";
    "ALSF_TAB_OPT" = "Close Tabs to Left";
    "ALSF_TAB_SHIFT" = "Close Tabs to Right";
    "ALSF_UID" = "639C263B-B7DB-4B04-8074-ED3CEED943EE";
    "ALSF_URL_CTRL" = "Search in Bookmarks";
    "ALSF_URL_FN" = "Open in Private Window";
    "ALSF_URL_OPT" = "Open in Chrome";
    "ALSF_URL_SHIFT" = "";
    "AW_SESSION_ID" = N3HHMO6L0LJ7H6QDDQQG0CSW;
    action = browse;
}
\-------------------------/
[2017-11-28 01:00:18][utility.debug] Processing output of 'input.scriptfilter' with arg ''
[2017-11-28 01:00:18][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 01:00:18][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 01:00:18][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 01:00:18][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 01:00:18][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 01:00:18][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 01:00:18][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 01:00:18][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 01:00:18][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 01:00:18][input.scriptfilter] Queuing argument ''

[deanishe]

The log looks fine. The workflow works perfectly for me.

I can't access the folders at all

You're going to have to provide a better description than that.

[nikitavoloboev]

The script filter quits for me.

I made a quick screencast here.

[deanishe]

That screencast doesn't match the log you posted.

I can see from the screencast that you've edited the workflow.

It's working perfectly for me, so unless somebody else reports the same issue, I'm going to assume that you broke it with your edits (it wouldn't be the first time).

[nikitavoloboev]

I haven't actually made any edits before the moment it was working and the update after which things did stop working.

Fortunately I don't actually use folder search feature that often so it's not so bad that it stopped working. The only edits I've done to the workflow was add two external triggers (bookmark and current tabs search) and adding my applescript script to search bookmarks in Safari. And also changing things in the configuration sheet (which is actually awesome that you can do it).

So yeah. No idea why this happens.

Here's one more log snapshot, perhaps it is different:

[2017-11-28 20:54:28][trigger.external] Processing output of 'input.scriptfilter' with arg ''
[2017-11-28 20:54:28][input.scriptfilter] Queuing argument ''
[2017-11-28 20:54:28][input.scriptfilter] Script with argument '' finished
[2017-11-28 20:54:28][STDERR: input.scriptfilter] 💜
20:54:28 workflow.go:614: ------- Safari Assistant/0.4.4 (AwGo/0.13) -------
20:54:28 update.go:159: Latest release: 0.4.4
20:54:28 folders.go:25: query=
20:54:28 feedback.go:431: Sent 13 result(s) to Alfred
20:54:28 update.go:171: 20h0m since last check for update
20:54:28 workflow.go:790: ---------------------- 28ms ----------------------
[2017-11-28 20:54:28][input.scriptfilter] {
  "variables": {
    "AW_SESSION_ID": "K69ADX8GJ629CQKB4OT2POVF"
  },
  "items": [
    {
      "title": "Favorites (4 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "639C263B-B7DB-4B04-8074-ED3CEED943EE",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 4 bookmark(s)",
          "variables": {
            "ALSF_UID": "639C263B-B7DB-4B04-8074-ED3CEED943EE",
            "action": "open"
          }
        }
      }
    },
    {
      "title": "Bookmarks Menu (0 bookmarks)",
      "subtitle": "",
      "valid": false,
      "icon": {
        "path": "icons/folder.png"
      }
    },
    {
      "title": "Reading List (0 bookmarks)",
      "subtitle": "",
      "valid": false,
      "icon": {
        "path": "icons/folder.png"
      }
    },
    {
      "title": "w:top (14 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "A4503744-7C59-441A-BE7C-FE214F1938C2",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 14 bookmark(s)",
          "variables": {
            "ALSF_UID": "A4503744-7C59-441A-BE7C-FE214F1938C2",
            "action": "open"
          }
        }
      }
    },
    {
      "title": "f:personal (11 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "A007516B-041C-43EC-BA35-690CEDD8653C",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 11 bookmark(s)",
          "variables": {
            "ALSF_UID": "A007516B-041C-43EC-BA35-690CEDD8653C",
            "action": "open"
          }
        }
      }
    },
    {
      "title": "d:code (1 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "91A72F4E-FCD9-4E8F-80FC-A108BF7ED0C4",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 1 bookmark(s)",
          "variables": {
            "ALSF_UID": "91A72F4E-FCD9-4E8F-80FC-A108BF7ED0C4",
            "action": "open"
          }
        }
      }
    },
    {
      "title": "a:analytics (5 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "F4F2DA79-F03F-46C3-BD68-DA85836D81B1",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 5 bookmark(s)",
          "variables": {
            "ALSF_UID": "F4F2DA79-F03F-46C3-BD68-DA85836D81B1",
            "action": "open"
          }
        }
      }
    },
    {
      "title": "e:events (1 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "B0DE671F-5819-4511-BDF7-0D9A22C8D2DD",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 1 bookmark(s)",
          "variables": {
            "ALSF_UID": "B0DE671F-5819-4511-BDF7-0D9A22C8D2DD",
            "action": "open"
          }
        }
      }
    },
    {
      "title": "t:track (1 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "FCD80583-D530-487E-AC6F-F83211F8BF8C",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 1 bookmark(s)",
          "variables": {
            "ALSF_UID": "FCD80583-D530-487E-AC6F-F83211F8BF8C",
            "action": "open"
          }
        }
      }
    },
    {
      "title": "r:work (1 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "6E622B37-FEDB-4D24-82CC-B205BC44A4F7",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 1 bookmark(s)",
          "variables": {
            "ALSF_UID": "6E622B37-FEDB-4D24-82CC-B205BC44A4F7",
            "action": "open"
          }
        }
      }
    },
    {
      "title": "s:social (1 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "4D03C657-26B2-48C0-8107-D4AE8CB4EDDC",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 1 bookmark(s)",
          "variables": {
            "ALSF_UID": "4D03C657-26B2-48C0-8107-D4AE8CB4EDDC",
            "action": "open"
          }
        }
      }
    },
    {
      "title": "u:uni (4 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "3FC20651-E8BE-48CA-BD24-CD0465CC2A8C",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 4 bookmark(s)",
          "variables": {
            "ALSF_UID": "3FC20651-E8BE-48CA-BD24-CD0465CC2A8C",
            "action": "open"
          }
        }
      }
    },
    {
      "title": "hosts (2 bookmarks)",
      "subtitle": "",
      "valid": true,
      "icon": {
        "path": "icons/folder.png"
      },
      "variables": {
        "ALSF_UID": "28597CB6-EC4F-4A65-84AC-EAE0096A6F2D",
        "action": "browse"
      },
      "mods": {
        "cmd": {
          "subtitle": "Open 2 bookmark(s)",
          "variables": {
            "ALSF_UID": "28597CB6-EC4F-4A65-84AC-EAE0096A6F2D",
            "action": "open"
          }
        }
      }
    }
  ]
}
[2017-11-28 20:54:29][input.scriptfilter] Processing output of 'utility.debug' with arg ''
[2017-11-28 20:54:29][utility.debug] .
/--- DISPATCH IN ---\
query=
variables={
    "ALSF_HISTORY_ENTRIES" = 1000;
    "ALSF_INCLUDE_BOOKMARKLETS" = 0;
    "ALSF_SEARCH_HOSTNAMES" = 1;
    "ALSF_TAB_CTRL" = "Close Tab";
    "ALSF_TAB_FN" = "Open in Private Window";
    "ALSF_TAB_OPT" = "Close Tabs to Left";
    "ALSF_TAB_SHIFT" = "Close Tabs to Right";
    "ALSF_UID" = "639C263B-B7DB-4B04-8074-ED3CEED943EE";
    "ALSF_URL_CTRL" = "Search in Bookmarks";
    "ALSF_URL_FN" = "Open in Private Window";
    "ALSF_URL_OPT" = "Open in Chrome";
    "ALSF_URL_SHIFT" = "";
    "AW_SESSION_ID" = K69ADX8GJ629CQKB4OT2POVF;
    action = browse;
}
\-------------------/
[2017-11-28 20:54:29][utility.debug] Processing output of 'output.callexternaltrigger' with arg ''
[2017-11-28 20:54:29][trigger.external] Processing output of 'utility.debug' with arg ''
[2017-11-28 20:54:29][utility.debug] .
/--- DISPATCH OUT ---\
query=
variables={
    "ALSF_HISTORY_ENTRIES" = 1000;
    "ALSF_INCLUDE_BOOKMARKLETS" = 0;
    "ALSF_SEARCH_HOSTNAMES" = 1;
    "ALSF_TAB_CTRL" = "Close Tab";
    "ALSF_TAB_FN" = "Open in Private Window";
    "ALSF_TAB_OPT" = "Close Tabs to Left";
    "ALSF_TAB_SHIFT" = "Close Tabs to Right";
    "ALSF_UID" = "639C263B-B7DB-4B04-8074-ED3CEED943EE";
    "ALSF_URL_CTRL" = "Search in Bookmarks";
    "ALSF_URL_FN" = "Open in Private Window";
    "ALSF_URL_OPT" = "Open in Chrome";
    "ALSF_URL_SHIFT" = "";
    "AW_SESSION_ID" = K69ADX8GJ629CQKB4OT2POVF;
    action = browse;
}
\--------------------/
[2017-11-28 20:54:29][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 20:54:29][utility.filter] Processing output of 'utility.debug' with arg ''
[2017-11-28 20:54:29][utility.debug] .
/--- BROWSE FOLDER ---\
query=
variables={
    "ALSF_HISTORY_ENTRIES" = 1000;
    "ALSF_INCLUDE_BOOKMARKLETS" = 0;
    "ALSF_SEARCH_HOSTNAMES" = 1;
    "ALSF_TAB_CTRL" = "Close Tab";
    "ALSF_TAB_FN" = "Open in Private Window";
    "ALSF_TAB_OPT" = "Close Tabs to Left";
    "ALSF_TAB_SHIFT" = "Close Tabs to Right";
    "ALSF_UID" = "639C263B-B7DB-4B04-8074-ED3CEED943EE";
    "ALSF_URL_CTRL" = "Search in Bookmarks";
    "ALSF_URL_FN" = "Open in Private Window";
    "ALSF_URL_OPT" = "Open in Chrome";
    "ALSF_URL_SHIFT" = "";
    "AW_SESSION_ID" = K69ADX8GJ629CQKB4OT2POVF;
    action = browse;
}
\---------------------/
[2017-11-28 20:54:29][utility.debug] Processing output of 'output.callexternaltrigger' with arg ''
[2017-11-28 20:54:29][trigger.external] Processing output of 'utility.debug' with arg ''
[2017-11-28 20:54:29][utility.debug] .
/--- BROWSE FOLDER OUT ---\
query=
variables={
    "ALSF_HISTORY_ENTRIES" = 1000;
    "ALSF_INCLUDE_BOOKMARKLETS" = 0;
    "ALSF_SEARCH_HOSTNAMES" = 1;
    "ALSF_TAB_CTRL" = "Close Tab";
    "ALSF_TAB_FN" = "Open in Private Window";
    "ALSF_TAB_OPT" = "Close Tabs to Left";
    "ALSF_TAB_SHIFT" = "Close Tabs to Right";
    "ALSF_UID" = "639C263B-B7DB-4B04-8074-ED3CEED943EE";
    "ALSF_URL_CTRL" = "Search in Bookmarks";
    "ALSF_URL_FN" = "Open in Private Window";
    "ALSF_URL_OPT" = "Open in Chrome";
    "ALSF_URL_SHIFT" = "";
    "AW_SESSION_ID" = K69ADX8GJ629CQKB4OT2POVF;
    action = browse;
}
\-------------------------/
[2017-11-28 20:54:29][utility.debug] Processing output of 'input.scriptfilter' with arg ''
[2017-11-28 20:54:29][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 20:54:29][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 20:54:29][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 20:54:29][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 20:54:29][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 20:54:29][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 20:54:29][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 20:54:29][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 20:54:29][utility.debug] Processing output of 'utility.filter' with arg ''
[2017-11-28 20:54:29][input.scriptfilter] Queuing argument ''

Again, I don't mind it not working as I don't really use it currently. Thank you a lot if you do find what the problem is.