search

deanishe / alfred-workflow

Full-featured library for writing Alfred 3 & 4 workflows
https://www.deanishe.net/alfred-workflow/
Other
2.97k stars 232 forks source link

Issues with notify.notify in release version #187

Open deafmute1 opened 4 months ago

deafmute1 commented 4 months ago

Two issues that I encountered with notify due to undocumented/wrong documented behavior.

1) Version downloaded via pip has different signature vs main/docs. Pip version has signature notify(title, subtitle, message, sound), and raises ValueError if message == '', but main/docs have signature notify(title, subtitle, sound) with value error if title == subtitle == ''. I kept calling this function exactly as docs describe but getting ValueError...

2) notify.notify requires you have a file at workflowdir/icon.png, otherwise you get somewhat cryptic error. It doesn't describe the need for an icon anywhere in this project's docs.

deafmute1 commented 4 months ago

Now that I'm not getting Exceptions, it just fails silently, no notification produced.

Dig down a bit, and directly called the generate applet (cachedir/alfred/package/Notificator.app..../applet) with various differing amounts of strings, regardless of what I input it silently fails (M1 Mac on 14.5 Sonoma).

deafmute1 commented 4 months ago

Okay reading around the issues more and I see this repo is py2.7 and the version on pypi is a fork for py3 support. Would be good to include disclaimer on repo/archive the repo if no more work will occur here! its still very high on google and linked to from everywhere!