search

deanmcpherson / react-native-sortable-listview

Drag drop capable wrapper of ListView for React Native
MIT License
917 stars 235 forks source link

Adding a property for disabling animated scroll. #117

Closed matuszeg closed 6 years ago

matuszeg commented 6 years ago

This gives the option to disable animated scrolling, which might be something users want, but more importantly this is a temp fix for this issue here, https://github.com/deanmcpherson/react-native-sortable-listview/issues/97, that will allow for people to fix the ios scrolling problem temporarily while a long term solution is addressed.

nihgwu commented 6 years ago

Thanks for your contribution, I'll find if there is another way to solve the issue or I'm happy to land this

matuszeg commented 6 years ago

I appreciate the quick response. Hopefully there is a better solution, because it looks better with the animation. Thank you and all the other devs for all your hardwork on this project.

nihgwu commented 6 years ago

I'm so sorry I'm absent for such a long time leaving this open, I think that's the right solution for now, as the scrollTo takes no duration param, thanks so much

nihgwu commented 6 years ago

@chetstone can you release a new version as I've landed several important fixes

chetstone commented 6 years ago

Done. @deanmcpherson Could you please give @nihgwu permission to publish to npm? He understands the code much better than I do and has been doing a great job responding promptly to issues. I intend to continue to help as much as I can --- sorry about the delay in responding to this request.

deanmcpherson commented 6 years ago

No problem! I just added @nihgwu as another owner of the npm package. @chetstone

nihgwu commented 6 years ago

@chetstone @deanmcpherson Thanks