search

deanmcpherson / react-native-sortable-listview

Drag drop capable wrapper of ListView for React Native
MIT License
917 stars 235 forks source link

fix issue #125 - extra spacing at the bottom of list #128

Open EJohnF opened 6 years ago

EJohnF commented 6 years ago

I don't sure, why there was additional spacing for scrolling of two-row size. But at least it solve the problem #125

nihgwu commented 6 years ago

Thanks for you contributing, I've tested it, I think the extra spacing is still needed when you drag your item to the bottom, but we should use this.state.active.layout.frameHeight instead of this.state.active.layout.frameHeight * 2 for the extra spacing

BTW, there would be janky after the change, I'll figure out a better solution

EJohnF commented 6 years ago

or, may be, add this.state.active.layout.frameHeight only when there is no footer?